Re: [Buildroot] [PATCH] package/strace: download from Github

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Markus Mayer <mmayer@broadcom.com>
Cc: Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/strace: download from Github
Date: Sat, 28 May 2022 12:00:23 +0200	[thread overview]
Message-ID: <20220528100023.GD301044@scaer> (raw)
In-Reply-To: <20220527184501.1992852-1-mmayer@broadcom.com>

Mrkus, All,

On 2022-05-27 11:45 -0700, Markus Mayer via buildroot spake thusly:
> Some corporate networks may be blocking access to Russian servers.
> The server "strace.io" is in Russia, which will make it inaccessible
> from some networks.
> 
> Use Github instead to download the sources.
> 
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>

Applied to master, thanks.

> ---
> 
> Not sure if there is a precedence for such a change or if it'll be deemed
> acceptable. I am putting this out there in case it is considered helpful.

Yes, there's already been such switch in the past. We jsut have to
ensure one of the folowing:

  - if the archive filename did not change, it must be the exact same
    content as what we already use (i.e. the same hash), or it would
    conflict eith the cached archive we have on s.b.o.

  - if the archive content changed, we must ensure its filename changed,
    like we bump the version or something, to avoid aforementioned hash
    mismatch.

In this case, the hash did match, so it's (very probably!) the same file,
so that's OK.

Regards,
Yann E. MORIN.

> Thanks,
> -Markus
> 
>  package/strace/strace.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/strace/strace.mk b/package/strace/strace.mk
> index c35e0c84da22..67924d4b660a 100644
> --- a/package/strace/strace.mk
> +++ b/package/strace/strace.mk
> @@ -6,7 +6,7 @@
>  
>  STRACE_VERSION = 5.17
>  STRACE_SOURCE = strace-$(STRACE_VERSION).tar.xz
> -STRACE_SITE = https://strace.io/files/$(STRACE_VERSION)
> +STRACE_SITE = https://github.com/strace/strace/releases/download/v$(STRACE_VERSION)
>  STRACE_LICENSE = LGPL-2.1+
>  STRACE_LICENSE_FILES = COPYING LGPL-2.1-or-later
>  STRACE_CPE_ID_VENDOR = strace_project
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot