Re: [Buildroot] [PATCH v2 01/11] package: elf2flt: fix config menu entry description

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Damien,

On Mon, 30 May 2022 12:38:26 +0900
Damien Le Moal via buildroot <buildroot@buildroot.org> wrote:

> From: Damien Le Moal <damien.lemoal@wdc.com>
> 
> Keep the same style as other config menu entries by removing the
> question mark at the end of the elf2flt enable config option
> description.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>

Thanks for the patch, however I think that the correct fix is in fact
to drop this option entirely. Indeed, it doesn't do anything, and it
shouldn't do anything.

What decides whether host-elf2flt should be built or not is the
BR2_BINFMT_FLAT option in arch/Config.in. It is depending on this
option that the gcc package decides to build host-elf2flt:

package/gcc/gcc.mk:     $(if $(BR2_BINFMT_FLAT),host-elf2flt)

BR2_PACKAGE_HOST_ELF2FLT is only used in the definition of
BR2_STRIP_strip:

config BR2_STRIP_strip
        bool "strip target binaries"
        default y
        depends on !BR2_PACKAGE_HOST_ELF2FLT

and this should be replaced by:

	depends on BR2_BINFMT_ELF

So I think we should really get rid of package/elf2flt/Config.in.host
entirely.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot