Re: [Buildroot] [PATCH 1/2] package/wolftpm: new package, wolfTPM library for TPM2.0

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Dimi Tomov <dimi@tpm.dev>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/wolftpm: new package, wolfTPM library for TPM2.0
Date: Mon, 30 May 2022 23:31:25 +0200	[thread overview]
Message-ID: <20220530233125.1f257276@windsurf> (raw)
In-Reply-To: <20220530203001.574908-1-dimi@tpm.dev>

Hello,

The commit title should be just:

	package/wolftpm: new package

See below for more comments.

On Mon, 30 May 2022 23:30:00 +0300
Dimi Tomov <dimi@tpm.dev> wrote:

>  package/Config.in            |  1 +
>  package/wolftpm/Config.in    | 14 ++++++++++++++
>  package/wolftpm/wolftpm.hash |  2 ++
>  package/wolftpm/wolftpm.mk   | 29 +++++++++++++++++++++++++++++
>  4 files changed, 46 insertions(+)

An entry in the DEVELOPERS file is missing.

> diff --git a/package/wolftpm/Config.in b/package/wolftpm/Config.in
> new file mode 100644
> index 0000000000..497f5ae6e9
> --- /dev/null
> +++ b/package/wolftpm/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_WOLFTPM
> +	bool "wolftpm"
> +	depends on BR2_PACKAGE_WOLFSSL

This should be a "select", and you need to propagate the "depends on
BR2_TOOLCHAIN_HAS_THREADS" from wolfssl.

> +    select BR2_PACKAGE_WOLFSSL_ALL

Indentation is incorrect here, it should be intended with one tab.

> +	help
> +	  wolfTPM is a portable, open-source TPM 2.0 stack with
> +	  backward API compatibility, designed for embedded use.
> +	  No external dependencies, compact code size with low
> +	  resource usage.
> +
> +	  https://www.wolfssl.com/
> +
> +comment "wolfTPM needs the wolfSSL cryptographic library"
> +	depends on !BR2_PACKAGE_WOLFSSL

Replace this with:

comment "wolftpm needs a toolchain w/ threads"
	depends on !BR2_TOOLCHAIN_HAS_THREADS

> +WOLFTPM_VERSION = 2.3.1
> +WOLFTPM_SITE = $(call github,wolfSSL,wolfTPM,v$(WOLFTPM_VERSION))
> +WOLFTPM_INSTALL_STAGING = YES
> +

Empty line not needed.

> +WOLFTPM_LICENSE = GPL-2.0+
> +WOLFTPM_LICENSE_FILES = LICENSE
> +WOLFTPM_CPE_ID_VENDOR = wolfssl
> +
> +WOLFTPM_DEPENDENCIES = host-pkgconf
> +
> +# wolfTPM's source code is released without a configure script,
> +# therefore we need autoreconf
> +WOLFTPM_AUTORECONF = YES
> +
> +WOLFTPM_CONF_OPTS = --disable-examples --enable-devtpm --with-wolfcrypt=$(TARGET_DIR)/usr/

This --with-wolfcrypt option value looks suspicious. What is this
option meant for?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot