From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Christian Stewart <christian@paral.in>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/go: set goos variable to linux
Date: Sat, 4 Jun 2022 18:34:04 +0200 [thread overview]
Message-ID: <20220604163404.GO427639@scaer> (raw)
In-Reply-To: <20220521035129.493797-1-christian@paral.in>
Christian, All,
On 2022-05-20 20:51 -0700, Christian Stewart via buildroot spake thusly:
> This commit fixes a build error when the host environment has GOOS set to
> something other than "linux." For example,
>
> cd ./buildroot
> GOOS="js" make
>
> This will cause a build failure. Override GOOS to be either empty for host
> packages or set to "linux" for target packages.
>
> Signed-off-by: Christian Stewart <christian@paral.in>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/go/go.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/go/go.mk b/package/go/go.mk
> index 305a4926ee..f9445c7dd3 100644
> --- a/package/go/go.mk
> +++ b/package/go/go.mk
> @@ -73,6 +73,7 @@ endif
> HOST_GO_TOOLDIR = $(HOST_GO_ROOT)/pkg/tool/linux_$(GO_GOARCH)
> HOST_GO_TARGET_ENV = \
> $(HOST_GO_COMMON_ENV) \
> + GOOS="linux" \
> GOARCH=$(GO_GOARCH) \
> GOCACHE="$(HOST_GO_TARGET_CACHE)" \
> CC="$(TARGET_CC)" \
> @@ -95,6 +96,7 @@ endif
> HOST_GO_CROSS_ENV = \
> CC_FOR_TARGET="$(TARGET_CC)" \
> CXX_FOR_TARGET="$(TARGET_CXX)" \
> + GOOS="linux" \
> GOARCH=$(GO_GOARCH) \
> $(if $(GO_GO386),GO386=$(GO_GO386)) \
> $(if $(GO_GOARM),GOARM=$(GO_GOARM)) \
> @@ -109,6 +111,7 @@ endif # BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
> # For the convenience of host golang packages
> HOST_GO_HOST_ENV = \
> $(HOST_GO_COMMON_ENV) \
> + GOOS="" \
> GOARCH="" \
> GOCACHE="$(HOST_GO_HOST_CACHE)" \
> CC="$(HOSTCC_NOCCACHE)" \
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-04 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 3:51 [Buildroot] [PATCH 1/1] package/go: set goos variable to linux Christian Stewart via buildroot
2022-06-04 16:34 ` Yann E. MORIN [this message]
2022-06-07 18:47 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220604163404.GO427639@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=christian@paral.in \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox