From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 6/7] support/scripts/gen-bootlin-toolchains: properly take into account !BR2_STATIC_LIBS for glibc toolchains
Date: Sun, 5 Jun 2022 23:56:46 +0200 [thread overview]
Message-ID: <20220605235646.6057d743@windsurf> (raw)
In-Reply-To: <20220605202411.GU427639@scaer>
On Sun, 5 Jun 2022 22:24:11 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > for arch, details in arches.items():
> > - f.write("\tdefault y if %s\n" % " && ".join(details['conditions']))
> > + conditions = details['conditions'].copy()
> > + if set([t.libc for t in toolchains if t.arch == arch]) == set(['glibc']):
>
> What about:
>
> if 'glibc' in [t.libc for t in toolchains if t.arch == arch]
No, that would not work. We want to match if *only* glibc is available
as a C library, not if glibc is one of the supported C libraries.
If [t.libc for t in toolchains if t.arch == arch] contains glibc and
uclibc, we should *not* add the !BR2_STATIC_LIBS dependency, because
uclibc can be used in the BR2_STATIC_LIBS=y scenario.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-05 21:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 19:42 [Buildroot] [PATCH 0/7] Fix a number of toolchain dependency issues Thomas Petazzoni via buildroot
2022-06-05 19:42 ` [Buildroot] [PATCH 1/7] package/uclibc: introduce and use BR2_PACKAGE_UCLIBC_ARCH_SUPPORTS and BR2_PACKAGE_UCLIBC_SUPPORTS Thomas Petazzoni via buildroot
2022-06-05 19:42 ` [Buildroot] [PATCH 2/7] package/glibc: introduce and use BR2_PACKAGE_GLIBC_ARCH_SUPPORTS and BR2_PACKAGE_GLIBC_SUPPORTS Thomas Petazzoni via buildroot
2022-06-05 19:42 ` [Buildroot] [PATCH 3/7] package/musl: introduce and use BR2_PACKAGE_MUSL_ARCH_SUPPORTS and BR2_PACKAGE_MUSL_SUPPORTS Thomas Petazzoni via buildroot
2022-06-05 19:42 ` [Buildroot] [PATCH 4/7] Config.in: only allow BR2_STATIC_LIBS on supported libc/arch Thomas Petazzoni via buildroot
2022-06-05 19:42 ` [Buildroot] [PATCH 5/7] arch/Config.in.powerpc: disable some variants on ppc64le Thomas Petazzoni via buildroot
2022-06-06 9:45 ` Romain Naour
2022-06-07 2:41 ` Joel Stanley
2022-06-05 19:42 ` [Buildroot] [PATCH 6/7] support/scripts/gen-bootlin-toolchains: properly take into account !BR2_STATIC_LIBS for glibc toolchains Thomas Petazzoni via buildroot
2022-06-05 20:24 ` Yann E. MORIN
2022-06-05 20:28 ` Yann E. MORIN
2022-06-05 21:57 ` Thomas Petazzoni via buildroot
2022-06-05 21:56 ` Thomas Petazzoni via buildroot [this message]
2022-06-05 19:42 ` [Buildroot] [PATCH 7/7] toolchain/toolchain-external/toolchain-external-bootlin: regenerate with correct !BR2_STATIC_LIBS handling Thomas Petazzoni via buildroot
2022-06-06 10:24 ` [Buildroot] [PATCH 0/7] Fix a number of toolchain dependency issues Yann E. MORIN
2022-06-06 13:17 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220605235646.6057d743@windsurf \
--to=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox