From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>,
Romain Naour <romain.naour@gmail.com>,
Buildroot List <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [Buildroot] [PATCH 01/11] support/scripts/gen-bootlin-toolchains: fix RISC-V 64-bit toolchain description
Date: Tue, 7 Jun 2022 22:35:42 +0200 [thread overview]
Message-ID: <20220607203553.3307479-2-thomas.petazzoni@bootlin.com> (raw)
In-Reply-To: <20220607203553.3307479-1-thomas.petazzoni@bootlin.com>
We now support both MMU-enabled and MMU-less RISC-V 64-bit
configurations. However, the Bootlin toolchain for RISC-V 64-bit only
supports MMU-enabled configurations, but the current logic in
toolchain/toolchain-external/toolchain-external-bootlin/ does not take
this into account, and allows selecting the Booltin toolchain for
MMU-less RISC-V 64-bit configurations.
To fix this, the gen-bootlin-toolchains script is modified to add the
BR2_USE_MMU dependency to the description of the RISC-V 64-bit
toolchain.
However, the BR2_USE_MMU dependency was also added for glibc and musl
toolchains unconditionally, so to avoid duplicating the dependency, we
now only add it only if not already present in the list of
dependencies for this toolchain.
This will allow to fix:
http://autobuild.buildroot.net/results/d6aee9b275b1ec399aea59758ac8f69fdc5691fc/
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
support/scripts/gen-bootlin-toolchains | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/support/scripts/gen-bootlin-toolchains b/support/scripts/gen-bootlin-toolchains
index 97a744340a..16773cd9cb 100755
--- a/support/scripts/gen-bootlin-toolchains
+++ b/support/scripts/gen-bootlin-toolchains
@@ -159,7 +159,7 @@ arches = {
'prefix': 'riscv32',
},
'riscv64-lp64d': {
- 'conditions': ['BR2_riscv', 'BR2_riscv_g', 'BR2_RISCV_64', 'BR2_RISCV_ABI_LP64D'],
+ 'conditions': ['BR2_riscv', 'BR2_riscv_g', 'BR2_RISCV_64', 'BR2_RISCV_ABI_LP64D', 'BR2_USE_MMU'],
'prefix': 'riscv64',
},
's390x-z13': {
@@ -312,13 +312,15 @@ class Toolchain:
selects.append("BR2_TOOLCHAIN_EXTERNAL_UCLIBC")
elif frag.startswith("BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC"):
# glibc needs mmu support
- depends.append("BR2_USE_MMU")
+ if "BR2_USE_MMU" not in depends:
+ depends.append("BR2_USE_MMU")
# glibc doesn't support static only configuration
depends.append("!BR2_STATIC_LIBS")
selects.append("BR2_TOOLCHAIN_EXTERNAL_GLIBC")
elif frag.startswith("BR2_TOOLCHAIN_EXTERNAL_CUSTOM_MUSL"):
# musl needs mmu support
- depends.append("BR2_USE_MMU")
+ if "BR2_USE_MMU" not in depends:
+ depends.append("BR2_USE_MMU")
selects.append("BR2_TOOLCHAIN_EXTERNAL_MUSL")
# gcc version
--
2.35.3
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-07 20:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 20:35 [Buildroot] [PATCH 00/11] Another set of Bootlin toolchain integration improvements Thomas Petazzoni via buildroot
2022-06-07 20:35 ` Thomas Petazzoni via buildroot [this message]
2022-06-07 20:35 ` [Buildroot] [PATCH 02/11] support/testing, toolchain/toolchain-external/toolchain-external-bootlin: regenerate with latest gen-bootlin-toolchains script Thomas Petazzoni via buildroot
2022-06-07 20:35 ` [Buildroot] [PATCH 03/11] support/scripts/gen-bootlin-toolchains: improve dependencies of ARM toolchains Thomas Petazzoni via buildroot
2022-06-07 20:35 ` [Buildroot] [PATCH 04/11] toolchain/toolchain-external/toolchain-external-bootlin: regenerate with BR2_ARM dependency Thomas Petazzoni via buildroot
2022-06-07 20:35 ` [Buildroot] [PATCH 05/11] support/scripts/gen-bootlin-toolchains: adjust dependencies of i686 toolchains Thomas Petazzoni via buildroot
2022-06-07 20:35 ` [Buildroot] [PATCH 06/11] toolchain/toolchain-external/toolchain-external-bootlin: regenerate after i686 toolchain dependency fixes Thomas Petazzoni via buildroot
2022-06-07 20:35 ` [Buildroot] [PATCH 07/11] toolchain/toolchain-external: add BR2_TOOLCHAIN_EXTERNAL_HAS_NO_GDBSERVER option Thomas Petazzoni via buildroot
2022-06-07 20:35 ` [Buildroot] [PATCH 08/11] support/scripts/gen-bootlin-toolchains: make use of BR2_TOOLCHAIN_EXTERNAL_HAS_NO_GDBSERVER Thomas Petazzoni via buildroot
2022-06-07 20:35 ` [Buildroot] [PATCH 09/11] toolchain/toolchain-external/toolchain-external-bootlin: regenerate with BR2_TOOLCHAIN_EXTERNAL_HAS_NO_GDBSERVER Thomas Petazzoni via buildroot
2022-06-07 20:35 ` [Buildroot] [PATCH 10/11] support/scripts/gen-bootlin-toolchains: add support for ARMv7 big endian toolchain Thomas Petazzoni via buildroot
2022-06-07 20:35 ` [Buildroot] [PATCH 11/11] support/testing, toolchain/toolchain-external/toolchain-external-bootlin: regenerate with " Thomas Petazzoni via buildroot
2022-07-11 17:16 ` [Buildroot] [PATCH 00/11] Another set of Bootlin toolchain integration improvements Peter Korsgaard
2022-07-11 17:17 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607203553.3307479-2-thomas.petazzoni@bootlin.com \
--to=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox