From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 1/1] scripts/autobuild-run: add --no-toolchains-csv option and drop docopt
Date: Wed, 8 Jun 2022 00:01:28 +0200 [thread overview]
Message-ID: <20220608000128.046574c1@windsurf> (raw)
In-Reply-To: <20220413212745.480101-1-james.hilliard1@gmail.com>
Hello James,
On Wed, 13 Apr 2022 15:27:45 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Since docopt is unmaintained and less flexible than argparse lets
> drop it and migrate to argparse.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v2 -> v3:
> - suppress --no-toolchains-csv default output from help
> Changes v1 -> v2:
> - fix configparser
> ---
> scripts/autobuild-run | 202 ++++++-------
> scripts/docopt.LICENSE-MIT | 23 --
> scripts/docopt.py | 581 -------------------------------------
> 3 files changed, 93 insertions(+), 713 deletions(-)
> delete mode 100644 scripts/docopt.LICENSE-MIT
> delete mode 100644 scripts/docopt.py
I have finally applied this patch, but after splitting it into two
commits:
* One implementing the docopt -> argparse migration
* One implementing the --no-toolchains-csv option
Also, the --no-toolchains-csv option of utils/genrandconfig did not
exist back in the 2022.02.x branch, so when autobuild-run is executed
with --no-toolchains-csv, it never built any configuration on
2022.02.x, which is problematic.
I worked this around by doing a special case:
https://git.buildroot.org/buildroot-test/commit/?id=cae22243b75f7766095cbef196016b3b3143b677
I have now deployed the new script on two of the autobuilder instances
that I manage (gcc159 and gcc160).
Could you on your side also update to use the latest version of
autobuild-run, so that we are aligned?
Thanks a lot for this work, it has been extremely useful to find more
problematic configurations!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-07 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 21:27 [Buildroot] [PATCH v3 1/1] scripts/autobuild-run: add --no-toolchains-csv option and drop docopt James Hilliard
2022-06-07 22:01 ` Thomas Petazzoni via buildroot [this message]
2022-06-07 22:29 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608000128.046574c1@windsurf \
--to=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox