Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: kory.maincent@bootlin.com
Cc: scooby22@web.de, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/gcnano-binaries: bump version to 4.3.7
Date: Wed, 8 Jun 2022 15:35:11 +0200	[thread overview]
Message-ID: <20220608153511.76266cac@windsurf> (raw)
In-Reply-To: <20220608132957.68895-1-kory.maincent@bootlin.com>

Hello,

Commit title has an issue, you're bumping to 6.4.7

On Wed,  8 Jun 2022 15:29:57 +0200
kory.maincent@bootlin.com wrote:

> -GCNANO_BINARIES_LIBRARIES = \
> -	libgbm_viv libEGL libGAL libgbm libGLESv1_CM \
> -	libGLESv2 libGLSLC libOpenVG libVSC
> -
>  GCNANO_BINARIES_USERLAND_SUBDIR = gcnano-userland-multi-$(GCNANO_BINARIES_USERLAND_VERSION)
>  
> -GCNANO_BINARIES_PKG_CONFIGS = egl gbm glesv1_cm glesv2 vg
> -
>  define GCNANO_BINARIES_INSTALL
> -	$(foreach lib,$(GCNANO_BINARIES_LIBRARIES), \
> -		$(INSTALL) -D -m 0755 $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/usr/lib/$(lib).$(GCNANO_BINARIES_LIB_VERSION).multi.release.so \
> -			$(1)/usr/lib/$(lib).$(GCNANO_BINARIES_LIB_VERSION).multi.release.so ; \
> -		cp -a $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/usr/lib/$(lib).so* $(1)/usr/lib
> -	)
> +	cd $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/release/drivers/ ; \
> +	find . -type f -exec $(INSTALL) -D -m 0755 {} $(1)/usr/lib/{} \; ; \
> +	find . -type l -exec cp -a {} $(1)/usr/lib \; ; \

The ; \ at the end is not needed, it is the last line of the command.

> +	cp -a $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/release/include/* $(1)/usr/include/
> +	ln -s gbm/gbm.h $(1)/usr/include/gbm.h
> +	cd $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/pkgconfig/ ; \
> +	for file in * ; do \
> +		sed -e "s|#PREFIX#|/usr|" $$file > $$file.temp ; \
> +		$(INSTALL) -D -m 0644 $$file.temp $(1)/usr/lib/pkgconfig/$$file ; \
> +		rm $$file.temp ; \

I'd say you can leave the $$file.tmp around in the build directory, it
will not cause any problem.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-06-08 13:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 13:29 [Buildroot] [PATCH] package/gcnano-binaries: bump version to 4.3.7 Kory Maincent via buildroot
2022-06-08 13:35 ` Thomas Petazzoni via buildroot [this message]
2022-06-08 13:46   ` Köry Maincent via buildroot
2022-06-08 14:34     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220608153511.76266cac@windsurf \
    --to=buildroot@buildroot.org \
    --cc=kory.maincent@bootlin.com \
    --cc=scooby22@web.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox