From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Martin Doucha <mdoucha@suse.cz>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
Li Wang <liwang@redhat.com>, Cyril Hrubis <chrubis@suse.cz>,
Buildroot Mailing List <buildroot@buildroot.org>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
ltp@lists.linux.it
Subject: Re: [Buildroot] [PATCH 2/2] kvm: Fix undefined reference to __stack_chk_fail()
Date: Thu, 9 Jun 2022 14:26:16 +0200 [thread overview]
Message-ID: <20220609142616.2483414f@windsurf> (raw)
In-Reply-To: <5d4a4e2b-4d1d-88d6-4905-67083c154775@suse.cz>
On Thu, 9 Jun 2022 10:26:55 +0200
Martin Doucha <mdoucha@suse.cz> wrote:
> > diff --git a/testcases/kernel/kvm/Makefile b/testcases/kernel/kvm/Makefile
> > index 8d5193d8e..bce1a4eb5 100644
> > --- a/testcases/kernel/kvm/Makefile
> > +++ b/testcases/kernel/kvm/Makefile
> > @@ -9,7 +9,7 @@ ASFLAGS =
> > CPPFLAGS += -I$(abs_srcdir)/include
> > GUEST_CPPFLAGS = $(CPPFLAGS) -DCOMPILE_PAYLOAD
> > GUEST_CFLAGS = -ffreestanding -O2 -Wall -fno-asynchronous-unwind-tables -mno-mmx -mno-sse
> > -GUEST_LDFLAGS = -nostdlib -Wl,--build-id=none
> > +GUEST_LDFLAGS = -nostdlib -Wl,--build-id=none -fstack-protector
>
> We should use -fno-stack-protector here instead. Your patch probably
> enables linking of libssp despite -nostdlib which we don't want. The GCC
> stack protector may also break tests because bootstrap initializes stack
> manually instead of letting GCC handle it.
I agree. Assuming -nostdlib means you're building freestanding code,
then indeed, -fno-stack-protector is most likely what you want.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-09 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 18:43 [Buildroot] [PATCH 0/2] LTP compilation fixes for buildroot toolchains Petr Vorel
2022-06-06 18:43 ` [Buildroot] [PATCH 1/2] kvm: Fix compilation on x86 Petr Vorel
2022-06-06 18:43 ` [Buildroot] [PATCH 2/2] kvm: Fix undefined reference to __stack_chk_fail() Petr Vorel
[not found] ` <5d4a4e2b-4d1d-88d6-4905-67083c154775@suse.cz>
2022-06-09 12:26 ` Thomas Petazzoni via buildroot [this message]
[not found] ` <024cf3d9-f9c1-80a4-8b06-799309912c7f@jv-coder.de>
2022-06-13 21:31 ` [Buildroot] [LTP] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609142616.2483414f@windsurf \
--to=buildroot@buildroot.org \
--cc=chrubis@suse.cz \
--cc=fontaine.fabrice@gmail.com \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox