Re: [Buildroot] [PATCH 1/1] package/noip: fix static build

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed,  8 Jun 2022 21:56:18 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Pass TARGET_LDFLAGS (which will contain -static) through LIBS (as
> LDFLAGS is not supported) to fix the following static build failure
> (e.g. with musl):
> 
> /home/autobuild/autobuild/instance-15/output-1/host/lib/gcc/microblazeel-buildroot-linux-musl/10.3.0/../../../../microblazeel-buildroot-linux-musl/bin/ld: /home/autobuild/autobuild/instance-15/output-1/host/lib/gcc/microblazeel-buildroot-linux-musl/10.3.0/libgcc.a(unwind-dw2.o): in function `__gthread_once':
> /home/autobuild/autobuild/instance-15/output-1/build/host-gcc-final-10.3.0/build/microblazeel-buildroot-linux-musl/libgcc/gthr-default.h:700: undefined reference to `pthread_once'
> 
> While at it, drop CFLAGS (which is not supported by Makefile)

Be careful with this: $(CFLAGS) is used by implicit make rules, so even
if it's not visible in the Makefile, CFLAGS may be used by make.

However, in the particular case of this project, they don't rely on
implicit make rules, as their make rule is:

${TGT}: Makefile ${TGT}.c 
        ${CC} -Wall -g -D${ARCH} -DPREFIX=\"${PREFIX}\" ${TGT}.c -o ${TGT} ${LIBS}

So indeed, passing CFLAGS has no effect.

However, what you could do is:

	LIBS="$(TARGET_CPPFLAGS) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)"

Yes, it's a hack, and it will need a comment in the .mk file, but at
least with this, all flags are properly passed :-)

Cheers,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot