From: Adrian Perez de Castro <aperez@igalia.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select debugutils for multimedia
Date: Thu, 23 Jun 2022 23:16:28 +0200 [thread overview]
Message-ID: <20220623231628.GC3175@momiji> (raw)
In-Reply-To: <20220623045526.2152211-1-james.hilliard1@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2483 bytes --]
Hello,
On Wed, 22 Jun 2022 22:55:26 -0600 James Hilliard <james.hilliard1@gmail.com> wrote:
> When using webkit with multimedia support the fakevideosink element
> is used in some places, as such we should select debugutils which
> provides fakevideosink when building with multimedia support.
Makes sense. While there is a fallback for when fakevideosink is not
available, it's slightly less efficient. Also the fallback didn't work
in versions <2.36.0 and WebKit crashed instead.
> See:
> https://github.com/WebKit/WebKit/blob/12086bcde7a296a07dbb4ac6d2ff0030b297305a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L3863
>
> Additionally webkit may also use the fpsdisplaysink element which
> is also provided by debugutils.
>
> See:
> https://github.com/WebKit/WebKit/blob/12086bcde7a296a07dbb4ac6d2ff0030b297305a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L3897
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Acked-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/webkitgtk/Config.in | 1 +
> package/wpewebkit/Config.in | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
> index 052800c8cf..2575108363 100644
> --- a/package/webkitgtk/Config.in
> +++ b/package/webkitgtk/Config.in
> @@ -95,6 +95,7 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
> bool "multimedia support"
> select BR2_PACKAGE_GSTREAMER1
> select BR2_PACKAGE_GST1_PLUGINS_BAD
> + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS
> select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX
> select BR2_PACKAGE_GST1_PLUGINS_BASE
> select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> index 8e80c73302..f50e0da21c 100644
> --- a/package/wpewebkit/Config.in
> +++ b/package/wpewebkit/Config.in
> @@ -88,6 +88,7 @@ config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
> bool "multimedia support"
> select BR2_PACKAGE_GSTREAMER1
> select BR2_PACKAGE_GST1_PLUGINS_BAD
> + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS
> select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX
> select BR2_PACKAGE_GST1_PLUGINS_BASE
> select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-23 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 4:55 [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select debugutils for multimedia James Hilliard
2022-06-23 21:16 ` Adrian Perez de Castro [this message]
2022-06-25 6:38 ` Peter Korsgaard
2022-07-22 6:15 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623231628.GC3175@momiji \
--to=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox