Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Christian Stewart <christian@paral.in>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] go: patching dependency versions w/ go modules?
Date: Sun, 26 Jun 2022 01:20:22 +0200	[thread overview]
Message-ID: <20220626012022.48814280@windsurf> (raw)
In-Reply-To: <CA+h8R2rjW4aTmTObDpKyrdMX1e=CqGzyeGHSg5sB-eeonz3LTg@mail.gmail.com>

Hello,

On Sat, 25 Jun 2022 15:37:36 -0700
Christian Stewart <christian@paral.in> wrote:

> There's a particular issue I've run into with the Go implementation
> while trying to fix the gocryptfs package.
> 
> Currently the process is:
> 
>  1. Download the package source code.
>  2. Run "go mod vendor" and re-bundle into a .tar.gz.
>  3. Hash the resulting .tar.gz
>  4. Extract it to the build/ tree
>  5. Apply any patches
>  6. Run the build.
> 
> The problem with this is, if we try to patch the versions of any
> dependencies, for example by editing go.mod and go.sum, this is after
> the download step at #2.
> 
> So currently it is not possible to change the version of dependencies
> with a patch.

Correct.

> Is there any clean way to fix this?

No, not with the current infrastructure indeed.

> The only thing I can think of is to add a new variable which contains
> a list of "go mod edit" commands to run just before "go mod vendor" in
> the download & extract step.
> 
> go mod edit -replace
> github.com/jacobsa/crypto=github.com/piggynl/jacobsa-crypto@xorblock-generic

I don't really have a good idea here, but whatever solution we come up
with should not be Go-specific, as it should also work for the Cargo
use-case (and possibly other similar situations in the future).

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-06-25 23:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-25 22:37 [Buildroot] go: patching dependency versions w/ go modules? Christian Stewart via buildroot
2022-06-25 23:20 ` Thomas Petazzoni via buildroot [this message]
2022-06-27 19:56   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220626012022.48814280@windsurf \
    --to=buildroot@buildroot.org \
    --cc=christian@paral.in \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox