Re: [Buildroot] [PATCH] package/python-pillow: fix host package build

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thomas, All,

On 2022-07-13 13:58 +0200, Thomas Petazzoni via buildroot spake thusly:
> In commit
> d8c5d9b53437741c79cd3d759de1fe81af9055fd ("package/python-pillow:
> enable host variant"), when support for the host variant of
> python-pillow was added, the fact that python-pillow has optional
> dependencies was not handled, and left python-pillow to autodetect its
> optional dependencies.
> 
> Unfortunately, without some config options, some of its dependencies
> are made mandatory, such as the JPEG library. Since for now such
> support is not needed in the host variant of python-pillow, we simply
> disable all optional dependencies.

Well, if some package needs host-python-pillow, that's most probably
because they are going to do some image manipulation at biuld time.

Disabling all image processing options (that require an external
library, but that's most of them?) is not so nice. It would maybe make
sense to enable all the image options for which we have host libraries.

Köry, what does your optee-os need from python-pillow? Would this patch
still work for it?

Regards,
Yann E. MORIN.

> To be consistent with the target variant, we also ensure to have
> host-pkgconf as a dependency of the host variant.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/python-pillow/python-pillow.mk | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/package/python-pillow/python-pillow.mk b/package/python-pillow/python-pillow.mk
> index 8c9cb86863..0d189ac0ca 100644
> --- a/package/python-pillow/python-pillow.mk
> +++ b/package/python-pillow/python-pillow.mk
> @@ -71,5 +71,18 @@ else
>  PYTHON_PILLOW_BUILD_OPTS += --disable-webp --disable-webpmux
>  endif
>  
> +HOST_PYTHON_PILLOW_DEPENDENCIES = host-pkgconf
> +HOST_PYTHON_PILLOW_BUILD_OPTS = \
> +	build_ext \
> +	--disable-freetype \
> +	--disable-jpeg \
> +	--disable-lcms \
> +	--disable-xcb \
> +	--disable-jpeg2000 \
> +	--disable-tiff \
> +	--disable-webp \
> +	--disable-webpmux
> +HOST_PYTHON_PILLOW_INSTALL_OPTS = $(HOST_PYTHON_PILLOW_BUILD_OPTS)
> +
>  $(eval $(python-package))
>  $(eval $(host-python-package))
> -- 
> 2.36.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot