From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Quentin Schulz <foss+buildroot@0leil.net>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/libcamera: add explicit dependency on libevent if libevent package to be built
Date: Sun, 17 Jul 2022 14:59:24 +0200 [thread overview]
Message-ID: <20220717125924.GE2107091@scaer> (raw)
In-Reply-To: <165770292986.1813977.9808714201757010261@Monstersaurus>
Kieran, Quentin, All,
On 2022-07-13 10:02 +0100, Kieran Bingham spake thusly:
> Quoting Quentin Schulz (2022-07-12 09:00:51)
> > On 7/11/22 21:53, Kieran Bingham wrote:
> > > Quoting Quentin Schulz (2022-07-11 14:18:23)
> > >> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> > >> If libevent is present in the sysroot, cam is built.
[--SNIP--]
> > >> This fixes the possible race by expliciting the dependency to libevent
> > >> if the libevent package is enabled. Otherwise, explicitly disable cam
> > >> building as it's already known that it isn't going to build.
> > > I'm not opposed to this as it fixes the race though. I guess it depends
> > > how much resistance there is to adding a specific libcamera kconfig
> > > option to select cam.
[--SNIP details--]
For now, I've applied just this patch. Since you said can is just an
optional, test component, that is good enough as is.
If there are more complex conditions and new dependencies in the future,
we can revisit that, and add a Kconfig option to explicitly enable cam.
That option would be responsible for 1) select-ing needed dependencies
in Kconfig, and 2) add the proper dependencies and config flags in the
.mk.
Until then, the current situation is good enough (for me!). Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-17 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 13:18 [Buildroot] [PATCH v2] package/libcamera: add explicit dependency on libevent if libevent package to be built Quentin Schulz
2022-07-11 19:53 ` Kieran Bingham
2022-07-12 8:00 ` Quentin Schulz
2022-07-13 9:02 ` Kieran Bingham
2022-07-17 12:59 ` Yann E. MORIN [this message]
2022-07-17 12:56 ` Yann E. MORIN
2022-08-10 10:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220717125924.GE2107091@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=foss+buildroot@0leil.net \
--cc=kieran.bingham@ideasonboard.com \
--cc=quentin.schulz@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox