From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Eloi Bail <eloi.bail@savoirfairelinux.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/bayer2rgb-neon: fix build
Date: Wed, 20 Jul 2022 18:33:23 +0200 [thread overview]
Message-ID: <20220720183323.0eb28663@windsurf> (raw)
In-Reply-To: <20220626084517.970430-1-fontaine.fabrice@gmail.com>
On Sun, 26 Jun 2022 10:45:17 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following build failure:
>
> /home/autobuild/autobuild/instance-12/output-1/host/lib/gcc/aarch64-buildroot-linux-uclibc/10.3.0/../../../../aarch64-buildroot-linux-uclibc/bin/ld: ./.libs/libbayer2rgb3.so: undefined reference to `__bayer2rgb_missing_convert_dumb_implementation'
>
> Fixes:
> - http://autobuild.buildroot.org/results/69a637b7f1422ce2bf04dda573abb09388b9a02d
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...-src-convert.c-remove-have_cplusplus.patch | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 package/bayer2rgb-neon/0001-src-convert.c-remove-have_cplusplus.patch
I have applied to fix the immediate build issue, but I am not entirely
convinced this is the completely correct fix.
Indeed, the function __bayer2rgb_missing_convert_dumb_implementation()
is not implemented anywhere. So as soon as C++ support is not
available, bayer2rgb-neon doesn't build. So the correct fix would be
(IMO) to drop this logic, and make C++ a requirement in the
configure.ac script.
Normally, this call to
__bayer2rgb_missing_convert_dumb_implementation() gets optimized away
by the dead code elimination gcc optimizations. But when you build with
-Og as it is the case in the autobuilder failure you're pointing to,
such optimization does not take place, and the call to
__bayer2rgb_missing_convert_dumb_implementation() is preserved, even
though it is never invoked practically at runtime.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-20 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 8:45 [Buildroot] [PATCH 1/1] package/bayer2rgb-neon: fix build Fabrice Fontaine
2022-07-20 16:33 ` Thomas Petazzoni via buildroot [this message]
2022-08-11 11:45 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720183323.0eb28663@windsurf \
--to=buildroot@buildroot.org \
--cc=eloi.bail@savoirfairelinux.com \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox