Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: andrea.barisani@withsecure.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/crucible: Pass 'osusergo netgo' tags
Date: Wed, 20 Jul 2022 18:38:56 +0200	[thread overview]
Message-ID: <20220720183856.742c4a09@windsurf> (raw)
In-Reply-To: <20220720125707.1899437-1-festevam@gmail.com>

Hello Fabio, Hello Andrea,

On Wed, 20 Jul 2022 09:57:07 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> The 'osusergo netgo' tags need to be passed when CGO_ENABLED=1.
> 
> Fixes:
> 
> http://autobuild.buildroot.net/results/48a39341ca3dcb3675b2876e680718c3e43f55aa
> http://autobuild.buildroot.net/results/897b4803f4f221c52899641a45708b49b7cb5f5c
> http://autobuild.buildroot.net/results/3a75c6b73a1f583d6db666eacc45c4debd9218e9
> 
> Suggested-by: Andrea Barisani <andrea.barisani@withsecure.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Could you provide more background about these osusergo and netgo tags?
Indeed, they don't seem to be specific to the crucible package, but are
apparently generic Go tags, at least according to
https://www.arp242.net/static-go.html, and they seem to be needed when
statically linking Go programs.

If that is the case, then I don't think the solution is to change
crucible.mk, but probably to have a more generic solution in
package/pkg-golang.mk. Or is that package-specific in some way?

Do we understand under which conditions these tags are needed?

Thanks in advance for your feedback!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-07-20 16:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 12:57 [Buildroot] [PATCH] package/crucible: Pass 'osusergo netgo' tags Fabio Estevam
2022-07-20 16:38 ` Thomas Petazzoni via buildroot [this message]
     [not found]   ` <8CF2C8F5-F7EA-43C2-80BA-1D4122D22A66@withsecure.com>
2022-07-20 20:24     ` Thomas Petazzoni via buildroot
2022-07-22 21:04       ` Arnout Vandecappelle
2022-07-22 21:15         ` Thomas Petazzoni via buildroot
2022-07-22 22:03           ` Arnout Vandecappelle
2022-07-23  0:41             ` Christian Stewart via buildroot
2022-07-23  8:54               ` Arnout Vandecappelle
2022-09-18 12:50                 ` Arnout Vandecappelle
2022-09-18 13:09                   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720183856.742c4a09@windsurf \
    --to=buildroot@buildroot.org \
    --cc=andrea.barisani@withsecure.com \
    --cc=festevam@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox