From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: "Michael Zimmermann" <sigmaepsilon92@gmail.com>,
"José Luis Salvador Rufo" <salvador.joseluis@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/zfs: fix pam support
Date: Sat, 23 Jul 2022 17:04:26 +0200 [thread overview]
Message-ID: <20220723150426.GD2641@scaer> (raw)
In-Reply-To: <20220723134249.268212-1-arnout@mind.be>
Arnout, All,
On 2022-07-23 15:42 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> The --enable option was added to CONF_ENV instead of CONF_OPTS. For this
> defconfig
>
> BR2_arm=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_LINUX_KERNEL=y
> BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> BR2_PACKAGE_ZFS=y
> BR2_PACKAGE_LINUX_PAM=y
>
> this yields
>
> /bin/sh: line 1: --enable-pam=yes: command not found
>
> While we're at it, also remove the =yes which we usually don't add.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/zfs/zfs.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
> index 07ce3295ec..0a6e4a3cfa 100644
> --- a/package/zfs/zfs.mk
> +++ b/package/zfs/zfs.mk
> @@ -52,7 +52,7 @@ endif
>
> ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
> ZFS_DEPENDENCIES += linux-pam
> -ZFS_CONF_ENV += --enable-pam=yes
> +ZFS_CONF_OPTS += --enable-pam
> else
> ZFS_CONF_OPTS += --disable-pam
> endif
> --
> 2.35.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-23 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 13:42 [Buildroot] [PATCH] package/zfs: fix pam support Arnout Vandecappelle (Essensium/Mind)
2022-07-23 15:04 ` Yann E. MORIN [this message]
2022-08-14 19:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220723150426.GD2641@scaer \
--to=yann.morin.1998@free.fr \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=salvador.joseluis@gmail.com \
--cc=sigmaepsilon92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox