Re: [Buildroot] [PATCH 1/1] package/gocryptfs: fix build against riscv

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sat, 23 Jul 2022 12:44:01 -0700
Christian Stewart <christian@paral.in> wrote:

> > You're patching go.mod/go.sum, and this patching happens after we have
> > done the vendoring of the dependencies in the download step (an issue
> > you have reported already), so how can this patch work? I am missing
> > something here?
> 
> The patch includes the changes to vendor/

Aaah, indeed, I missed that, but re-reading the patch it's now obvious.

> Go uses minimum version selection and indirect dependencies. If you change
> the version of a dependency, it will also update any dependencies to be at
> least the version selected by the updated dependency

Right.

> That said if you check the patch to vendor/ these are really just
> additional lines that explicitly say which version is imported, same
> versions as before, there were no changes to vendor/ outside the one crypto
> package.

But I see this:

-# github.com/jacobsa/oglematchers v0.0.0-20150720000706-141901ea67cd
-## explicit
-# github.com/jacobsa/oglemock v0.0.0-20150831005832-e94d794d06ff
-## explicit
-# github.com/jacobsa/ogletest v0.0.0-20170503003838-80d50a735a11
-## explicit
-# github.com/jacobsa/reqtrace v0.0.0-20150505043853-245c9e0234cb
-## explicit

So these lines are really removed.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot