Re: [Buildroot] [PATCH 2/2] package/libtalloc: bump version to 2.3.4

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Romain, David, All,

On 2022-07-23 19:15 +0200, Romain Naour spake thusly:
> Le 05/07/2022 à 15:44, David GOUARIN a écrit :
> > This version needs to define an environment variable in build and install steps.
> > This requires an upgrade to pkg_waf.mk.
> > 
> > Signed-off-by: David GOUARIN <david.gouarin@thalesgroup.com>
> > ---
> >  package/libtalloc/libtalloc.hash | 2 +-
> >  package/libtalloc/libtalloc.mk   | 5 ++++-
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/package/libtalloc/libtalloc.hash b/package/libtalloc/libtalloc.hash
> > index cbfd11e63b..0bc8edb695 100644
> > --- a/package/libtalloc/libtalloc.hash
> > +++ b/package/libtalloc/libtalloc.hash
> > @@ -1,3 +1,3 @@
> >  # Locally calculated
> > -sha256  6be95b2368bd0af1c4cd7a88146eb6ceea18e46c3ffc9330bf6262b40d1d8aaa  talloc-2.3.3.tar.gz
> > +sha256  179f9ebe265e67e4ab2c26cad2b7de4b6a77c6c212f966903382869f06be6505  talloc-2.3.4.tar.gz
> >  sha256  f8340c449dd64a55c6605b02fcad2aec6f473612ac6026739a22995380a8043c  talloc.h
> > diff --git a/package/libtalloc/libtalloc.mk b/package/libtalloc/libtalloc.mk
> > index 8cba699ea1..6a5e1ef4b6 100644
> > --- a/package/libtalloc/libtalloc.mk
> > +++ b/package/libtalloc/libtalloc.mk
> > @@ -4,7 +4,7 @@
> >  #
> >  ################################################################################
> >  
> > -LIBTALLOC_VERSION = 2.3.3
> > +LIBTALLOC_VERSION = 2.3.4
> >  LIBTALLOC_SOURCE = talloc-$(LIBTALLOC_VERSION).tar.gz
> >  LIBTALLOC_SITE = https://www.samba.org/ftp/talloc
> >  LIBTALLOC_LICENSE = LGPL-3.0+
> > @@ -40,6 +40,9 @@ else
> >  LIBTALLOC_CONF_OPTS += --disable-python
> >  endif
> >  
> > +LIBTALLOC_CONF_ENV += PYTHONHASHSEED=1
> > +LIBTALLOC_MAKE_ENV += PYTHONHASHSEED=1
> 
> This looks suspicious... PYTHONHASHSEED=1 was added upstream without explanation
> by this commit [1] before libtalloc 2.3.0.

I agree that this needs more explanations than just "this is needed to
build" (obviously it is needed to build, otherwise t would not be
there).

> About PYTHONHASHSEED [2].
> Why it's now needed? Have you tried without it?
> [1] https://salsa.debian.org/samba-team/talloc/-/commit/afb4e22c4cbc15b6b6cf824274b653eaaafe4cc5
> [2] https://docs.python.org/3/using/cmdline.html#envvar-PYTHONHASHSEED

The thing is that talloc is extracted out of the samba code, so looking
at the talloc repository does not yield interesting commit logs, just
"New upstream version 2.1.16" for the commit that introduced
PYTHONHASHSEED.

But looking t the samba code yields better results:

    19a4d3ca692e build: Workaround python3 hash order issues (for now)

    This works around python3 having a new hash seed each time it starts to allow
    a second "make" not to rebuild the world.

    This should probably be reverted once we find the hash that is causing
    the issue, but should reduce frustration for now.

So it looks like there is an issue in waf (which is written in python)
where it uses the .hash() of objects to decide whether to rebuild files
or nt, and of course, that changes every run because python uses a
different seed at every run (and rightly so). And so, people that
actively develop on samba do not want to rebuild everything when the
change a single file, obviously.

But in our case, in Buildroot, we do not need to do so. Indeed, we are
building the package just once, so we are not going to hit that
situation.

So, I do not think we need this.

David, can you try to see if the build succeeds without PYTHONHASHSEED?
If it really needs it (e.g. build failure, or runtime failure), then
please extend the commit log with the above information and the failure
reason. If it does not need it, then just respin the bump without.

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot