Re: [Buildroot] [PATCH 2/2] package/libtalloc: bump version to 2.3.4

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Romain, All,

On 2022-07-24 10:19 +0200, Romain Naour spake thusly:
> Le 24/07/2022 à 09:59, Yann E. MORIN a écrit :
> > On 2022-07-23 19:15 +0200, Romain Naour spake thusly:
> >> Le 05/07/2022 à 15:44, David GOUARIN a écrit :
> >>> This version needs to define an environment variable in build and install steps.
> >>> This requires an upgrade to pkg_waf.mk.
[--SNIP--]
> >>> +LIBTALLOC_CONF_ENV += PYTHONHASHSEED=1
> >>> +LIBTALLOC_MAKE_ENV += PYTHONHASHSEED=1
> >> This looks suspicious... PYTHONHASHSEED=1 was added upstream without explanation
> >> by this commit [1] before libtalloc 2.3.0.
> > I agree that this needs more explanations than just "this is needed to
> > build" (obviously it is needed to build, otherwise t would not be
> > there).
[--SNIP--]
> > But looking t the samba code yields better results:
> >     19a4d3ca692e build: Workaround python3 hash order issues (for now)
[--SNIP--]
> > David, can you try to see if the build succeeds without PYTHONHASHSEED?
> > If it really needs it (e.g. build failure, or runtime failure), then
> > please extend the commit log with the above information and the failure
> > reason. If it does not need it, then just respin the bump without.
> I found another commit adding the offending waf check:
> https://gitlab.com/samba-team/samba/-/commit/420bbb1d92fd2a28725b53f425ba3d214831b660
> because it doesn't work without PYTHONHASHSEED.

I am not sure "it doesn't work without PYTHONHASHSEED".

As samba developers, they need it to avoid rebuilding with each call to
'make'.

But for us, a waf package is only built once, so we should not have to
care about waf being confused during rebuilds, because we are not doing
rebuilds.

We really want to know that the build actually fails without it.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot