Re: [Buildroot] [PATCH v3] support/scripts/pkg-stats: migrate to CSS grid and inline javascript

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Sen,

On Fri, 22 Jul 2022 14:15:58 -0500
Sen Hastings <sen@phobosdpl.com> wrote:

> This migrates pkg-stats.html from html tables to CSS grid, allowing
> the use of newer, simpler javascript that is short enough to be
> inlined, instead of relying on externally hosted javascript.
> 
> Javascript sorting function was rewritten from scratch in ~55 lines,
> short enough to be inlined directly in the html.
> 
> Tables were redone in CSS grid, but with care taken to mimic existing
> "look and feel" of prevous implementation, albeit with slightly
> better responsive behavior and default styling characteristics.
> 
> Column labels are now "sticky" and stay stuck to the top of the
> viewport as you scroll down the page.
> 
> Also, css was rewritten in fewer lines and table elements were changed
> to divs (for grid support).
> 
> Other small misc fixes include quoted hrefs and document language
> declarations to make the w3c html validator happy.
> 
> Signed-off-by: Sen Hastings <sen@phobosdpl.com>

Thanks for this patch, but I'm seeing several issues now when I compare:

  http://autobuild.buildroot.net/stats/master.html (which uses your new code)

and

  http://autobuild.buildroot.net/stats/2022.02.x.html (which uses the old code)

Here is the list of issues:

 * Sorting is now very slow, to the point that Firefox complains that
   the page is slowing down the web browser. It was instantaneous in
   the old code, but way faster.

 * The "Latest version" cell is no longer with a dark orange/red
   background when the version doesn't match with the "Current
   version", these cells now have a green background, making one think
   that the package is up-to-date in Buildroot.

 * When sorting on a column, a small arrow appears indicating that the
   sorting has been done based on this column. But then when you sort
   by another column, the arrow appears on this new column, but doesn't
   disappear on the old one, so you no longer know which column was
   using for the sorting.

Do you think you could have a look at those issues?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot