Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Nicolas Carrier <nicolas.carrier@orolia.com>
Cc: "Peter Seiderer" <ps.report@gmx.net>,
	"Julien Corjon" <corjon.j@ecagroup.com>,
	"Gaël Portay" <gael.portay@collabora.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qt5/qt5webkit: fix compilation with linaro 7.3 / 7.5 toolchains
Date: Sun, 24 Jul 2022 12:33:35 +0200	[thread overview]
Message-ID: <20220724123335.0f64d17c@windsurf> (raw)
In-Reply-To: <20220310124106.2916278-1-nicolas.carrier@orolia.com>

On Thu, 10 Mar 2022 13:41:06 +0100
Nicolas Carrier <nicolas.carrier@orolia.com> wrote:

> An unitialized field in a structure, causes the following error:
>     platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:234:5: error: braces around scalar initializer for type ‘gboolean (*)(GstAppSink*, gpointer) {aka int (*)(_GstAppSink*, void*)}’
> 
> This commit applies a patch to qt5webkit to fix the compilation issue.
> 
> Signed-off-by: Nicolas Carrier <nicolas.carrier@orolia.com>
> ---
>  ...x-AudioFileReaderGStreamer-compilation.patch | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 package/qt5/qt5webkit/0005-fix-AudioFileReaderGStreamer-compilation.patch

Thanks for your patch. I looked into this, and the problem is not
related to Linaro toolchains, but a compatibility issue with GStreamer
newer than 1.19.x, which changed this GstAppSinkCallbacks structure. I
identified the upstream fix for this problem, backported it, and added
an explanation.

See the resulting commit at:

  https://git.buildroot.org/buildroot/commit/?id=bb50b821702841fdc75bf8151555cd401f764f07

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-07-24 10:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 12:41 [Buildroot] [PATCH 1/1] package/qt5/qt5webkit: fix compilation with linaro 7.3 / 7.5 toolchains Nicolas Carrier
2022-03-10 12:42 ` Nicolas Carrier
2022-07-24 10:33 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220724123335.0f64d17c@windsurf \
    --to=buildroot@buildroot.org \
    --cc=corjon.j@ecagroup.com \
    --cc=gael.portay@collabora.com \
    --cc=nicolas.carrier@orolia.com \
    --cc=ps.report@gmx.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox