Re: [Buildroot] [PATCH v4] package/opensc: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello José,

On Fri, 14 Jan 2022 09:08:52 +0200
José Pekkarinen <jose.pekkarinen@unikie.com> wrote:

> The patch will add package opensc. sourcery-arm
> toolchain triggers strict aliasing rules that upstream
> finds no easy way to fix. It is disabled for now until
> a proper solution is found upstream.

This story about sourcery-arm is no longer true, the problem was fixed
using --disable-strict.


> diff --git a/package/opensc/0001-Fix-maybe-uninitialized-errors.patch b/package/opensc/0001-Fix-maybe-uninitialized-errors.patch
> new file mode 100644
> index 0000000000..01b7a39818
> --- /dev/null
> +++ b/package/opensc/0001-Fix-maybe-uninitialized-errors.patch
> @@ -0,0 +1,83 @@
> +From bcb39d6f4d2dee6beb035cb2f3618174ec1cb2b0 Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?Jos=C3=A9=20Pekkarinen?= <jose.pekkarinen@unikie.com>
> +Date: Fri, 10 Dec 2021 13:54:26 +0200
> +Subject: [PATCH] Fix maybe uninitialized errors
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +PR: https://github.com/OpenSC/OpenSC/pull/2466

I have updated that to the link of the commit, since your PR has been merged.

> diff --git a/package/opensc/Config.in b/package/opensc/Config.in
> new file mode 100644
> index 0000000000..1b1ba0d38e
> --- /dev/null
> +++ b/package/opensc/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_OPENSC
> +	bool "opensc"
> +	depends on !BR2_STATIC_LIBS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_USE_MMU # fork()
> +	select BR2_PACKAGE_PCSC_LITE
> +	select BR2_PACKAGE_OPENSSL
> +	help
> +	  OpenSC provides a set of libraries and utilities to work
> +	  with smart cards.
> +
> +	  https://github.com/OpenSC/OpenSC/wiki
> +
> +comment "opensc needs a toolchain with dynamic library support distinct from sourcery-arm"
> +	depends on BR2_STATIC_LIBS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_USE_MMU

This was not correct for several reason:

 - The sourcery-arm issue no longer exists

 - The comment forgot about the threads dependency

 - The comment should be shown when thread support is *not* available,
   so when !BR2_TOOLCHAIN_HAS_THREADS

 - The comment should be seen when either static-libs is set *or*
   threads are not there.

All in all, the correct result is:

comment "opensc needs a toolchain with dynamic library, threads"
        depends on BR2_USE_MMU
        depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS

> +OPENSC_CONF_OPTS="--disable-strict"

Spaces around = are needed to follow the Buildroot coding-style, and
double quotes around --disable-strict should not be there.

I've applied with all those small fixes. Thanks a lot for your
contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot