From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/pkg-cargo.mk: enable -Z target-applies-to-host via env
Date: Mon, 25 Jul 2022 15:27:57 +0200 [thread overview]
Message-ID: <20220725132757.GE3168@scaer> (raw)
In-Reply-To: <20220109084732.2567404-1-james.hilliard1@gmail.com>
James, All,
Resurecting this old patch that was applied, but I have a question about
it, see below...
On 2022-01-09 01:47 -0700, James Hilliard spake thusly:
> This should be more reliable and fix the host == target bug when
> doing indirect invocations using the cargo env.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/pkg-cargo.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-cargo.mk b/package/pkg-cargo.mk
> index 47ae86bfae..b6cb65c4f0 100644
> --- a/package/pkg-cargo.mk
> +++ b/package/pkg-cargo.mk
> @@ -27,6 +27,7 @@
> PKG_CARGO_ENV = \
> CARGO_HOME=$(HOST_DIR)/share/cargo \
> __CARGO_TEST_CHANNEL_OVERRIDE_DO_NOT_USE_THIS="nightly" \
> + CARGO_UNSTABLE_TARGET_APPLIES_TO_HOST="true" \
> CARGO_TARGET_APPLIES_TO_HOST="false"
>
> ################################################################################
> @@ -88,7 +89,6 @@ define $(2)_BUILD_CMDS
> $$(if $$(BR2_ENABLE_DEBUG),--debug,--release) \
> --manifest-path Cargo.toml \
> --locked \
> - -Z target-applies-to-host \
Did you forget to remove it from the _INSTALL_TARGET_CMDS?
Regards,
Yann E. MORIN.
> $$($(2)_CARGO_BUILD_OPTS)
> endef
> else # ifeq ($(4),target)
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-25 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 8:47 [Buildroot] [PATCH 1/1] package/pkg-cargo.mk: enable -Z target-applies-to-host via env James Hilliard
2022-01-09 11:14 ` Thomas Petazzoni
2022-07-25 13:27 ` Yann E. MORIN [this message]
2022-07-25 18:52 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725132757.GE3168@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox