From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
Romain Naour <romain.naour@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/mesa3d: set cpp_rtti option
Date: Tue, 26 Jul 2022 10:47:26 +0200 [thread overview]
Message-ID: <20220726084726.GI3168@scaer> (raw)
In-Reply-To: <20220726063400.2321251-1-james.hilliard1@gmail.com>
James, Al;,
On 2022-07-26 00:34 -0600, James Hilliard spake thusly:
> This needs to be set based on BR2_PACKAGE_LLVM_RTTI being set.
BR2_PACKAGE_LLVM_RTTI is a sub-option of llvm, so it somehow means
that llvm should be a dependency of mesa3d, which your patch does not
add.
But we already have a conditional dependency on llvm, so this nex rtti
option should be a sub-condition of BR2_PACKAGE_MESA3D_LLVM?
Regards,
Yann E. MORIN.
> Fixes:
> - http://autobuild.buildroot.net/results/e2ebc9a73ed421aa6be44fe41bb5224cc12f699d
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/mesa3d/mesa3d.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> index 96520e2efd..652b5168d2 100644
> --- a/package/mesa3d/mesa3d.mk
> +++ b/package/mesa3d/mesa3d.mk
> @@ -94,6 +94,12 @@ else
> MESA3D_CONF_OPTS += -Dgallium-vc4-neon=disabled
> endif
>
> +ifeq ($(BR2_PACKAGE_LLVM_RTTI),y)
> +MESA3D_CONF_OPTS += -Dcpp_rtti=true
> +else
> +MESA3D_CONF_OPTS += -Dcpp_rtti=false
> +endif
> +
> # Drivers
>
> #Gallium Drivers
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-26 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 6:34 [Buildroot] [PATCH 1/1] package/mesa3d: set cpp_rtti option James Hilliard
2022-07-26 8:47 ` Yann E. MORIN [this message]
2022-07-26 15:31 ` James Hilliard
2022-07-26 16:28 ` Yann E. MORIN
2022-07-26 17:18 ` James Hilliard
2022-09-14 23:04 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726084726.GI3168@scaer \
--to=yann.morin.1998@free.fr \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox