From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Guillaume W. Bres" <guillaume.bressaix@gmail.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH] package/python-threadpoolctl: new host-only package
Date: Wed, 27 Jul 2022 08:27:36 +0200 [thread overview]
Message-ID: <20220727082736.53aa7bb2@windsurf> (raw)
In-Reply-To: <20220219182224.3397-1-guillaume.bressaix@gmail.com>
Hello Guillaume,
On Sat, 19 Feb 2022 19:22:24 +0100
"Guillaume W. Bres" <guillaume.bressaix@gmail.com> wrote:
> Tool to limit the number of threads used in the threadpool-backed
> of common native libraries used for scientific computing (e.g. BLAS and OpenMP).
>
> Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
>
> ---
> host-python-threadpoolctl is a requirement for python-scikitlearn,
> which first requires the current python-scipy work to be merged
>
> Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
I have the same comment as for python-joblib: could you resend this
patch as part of a patch series that includes python-scikitlearn. This
is to avoid having orphan host packages in Buildroot, which are not
used by anything, and therefore not buildable.
> +PYTHON_THREADPOOLCTL_VERSION = 3.1.0
> +PYTHON_THREADPOOLCTL_SITE = $(call github,joblib,threadpoolctl,$(PYTHON_THREADPOOLCTL_VERSION),$(PYTHON_THREADPOOLCTL_VERSION).tar.gz)
The github macro only takes 3 arguments, not 4.
> +PYTHON_THREADPOOLCTL_LICENSE = BSD-3-Clause
> +PYTHON_THREADPOOLCTL_LICENSE_FILES = LICENSE
> +
> +# threadpoolctl is originally built using 'flit' which
> +# simply symlinks $(@)/threadpoolctl.py to site-packages
We now have flit support in Buildroot. Could you have a look if this
help in making this package a bit better?
Thanks !
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-07-27 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 18:22 [Buildroot] [PATCH] package/python-threadpoolctl: new host-only package Guillaume W. Bres
2022-07-27 6:27 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727082736.53aa7bb2@windsurf \
--to=buildroot@buildroot.org \
--cc=buildroot@busybox.net \
--cc=guillaume.bressaix@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox