Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: John Keeping <john@metanate.com>
Cc: Martin Bark <martin@barkynet.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/connman: add an option to disable stats generation
Date: Thu, 28 Jul 2022 22:59:43 +0200	[thread overview]
Message-ID: <20220728225943.5ec6944e@windsurf> (raw)
In-Reply-To: <20220728175036.3262606-1-john@metanate.com>

On Thu, 28 Jul 2022 18:50:36 +0100
John Keeping <john@metanate.com> wrote:

> By default connman periodically saves network interface statistics into
> an mmap'd round robin file.  These are not accessible over the D-Bus
> interface and the only method to interact with this is ResetCounters()
> which is marked as experimental.
> 
> Continually writing statistics will increase drive wear and may not be
> desirable in some devices with limited flash erase cycles, so add an
> option to disable this.  Statistics are enabled by default to avoid
> changing the behaviour of existing configs.

Based on this description, I have chosen to not make it "default y". It
is unlikely that it is useful to anybody, and seems potentially
problematic.

So applied, after removing the "default y".

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-07-28 21:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 17:50 [Buildroot] [PATCH] package/connman: add an option to disable stats generation John Keeping
2022-07-28 20:59 ` Thomas Petazzoni via buildroot [this message]
2022-09-01 12:28 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220728225943.5ec6944e@windsurf \
    --to=buildroot@buildroot.org \
    --cc=john@metanate.com \
    --cc=martin@barkynet.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox