Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] support/scripts/check-host-rpath: send readelf error output to oblivion
Date: Sat, 30 Jul 2022 18:31:28 +0200	[thread overview]
Message-ID: <20220730163128.GY3168@scaer> (raw)
In-Reply-To: <20220727194212.15785a79@windsurf>

Thomas, All,

On 2022-07-27 19:42 +0200, Thomas Petazzoni via buildroot spake thusly:
> On Wed, 27 Jul 2022 18:40:57 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > > Of course, it would be nicer to only filter out those warnings, but
> > > filtering the error output without merging the error output into the
> > > standard output is tricky, so let's keep things simple. If there is
> > > really an error, readelf will abort.
> > Applied to master, thanks.
> Thanks! I must say I was kind of hoping you would come up with a way of
> keeping the errors displayed, while filtering the warnings :-)

That's going to be a little bit convoluted...

> But another issue in this script is that it doesn't have set -o
> pipefail, so if readelf fails, because the output is piped into another
> process, the script will not bork. Perhaps something to fix ;-) (hint hint!)

Using -o pipefail would not help, because the pipe is in a process
substitution:

    some-command < <( readelf blabla |sed foobar )

If we set -o pipefail, then the pipe will indeed fail, but the process
substitution will not fail.

So, meh.

However, check-host-rpath is slow as hell; it would highly benefit from
a makeover.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-07-30 16:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27 10:47 [Buildroot] [PATCH] support/scripts/check-host-rpath: send readelf error output to oblivion Thomas Petazzoni via buildroot
2022-07-27 16:40 ` Yann E. MORIN
2022-07-27 17:42   ` Thomas Petazzoni via buildroot
2022-07-30 16:31     ` Yann E. MORIN [this message]
2022-08-30 22:30 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220730163128.GY3168@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox