Re: [Buildroot] [PATCH v2 3/4] boot/ti-k3-image-gen: add new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Anand Gadiyar <gadiyar@ti.com>, Xuanhao Shi <x-shi@ti.com>,
	Suniel Mahesh <sunil@amarulasolutions.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/4] boot/ti-k3-image-gen: add new package
Date: Sun, 31 Jul 2022 10:30:02 +0200	[thread overview]
Message-ID: <20220731103002.6cf358cf@windsurf> (raw)
In-Reply-To: <3a3b2627-666f-a41b-a400-5e6d2671ff9c@benettiengineering.com>

Hello,

On Sun, 31 Jul 2022 03:04:28 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> > +config BR2_TARGET_TI_K3_IMAGE_GEN_SOC
> > +	string "SOC type for image gen"
> > +	depends on BR2_TARGET_TI_K3_IMAGE_GEN
> > +	help
> > +	  The target SoC option for image gen.
> > +	  For example, "am64x" for AM64X boards.  
> 
> As in previous patch I would add a "choice" instead of a "config"

As explained on a previous patch, it's fine to keep a free-form string
here.

> > +config BR2_TARGET_TI_K3_IMAGE_GEN_CONFIG
> > +	string "CONFIG type for image gen"
> > +	depends on BR2_TARGET_TI_K3_IMAGE_GEN
> > +	help
> > +	  The board config option for image gen.
> > +	  Usually "sk" or "evm".  
> 
> Ditto

And here (and especially here actually, we clearly don't want to have
an explicit list of all boards in Buildroot, it means that people
creating their own boards wouldn't be able to use this package, as
their board would not be listed here).

> > +TI_K3_IMAGE_GEN_VERSION = 08.04.00.005
> > +TI_K3_IMAGE_GEN_SITE = https://git.ti.com/cgit/k3-image-gen/k3-image-gen/snapshot
> > +TI_K3_IMAGE_GEN_SOURCE = k3-image-gen-$(TI_K3_IMAGE_GEN_VERSION).tar.gz
> > +TI_K3_IMAGE_GEN_LICENSE = BSD-3-Clause
> > +TI_K3_IMAGE_GEN_LICENSE_FILES = system-firmware-image-gen-1.0-manifest.html
> > +TI_K3_IMAGE_GEN_INSTALL_IMAGES = YES
> > +TI_K3_IMAGE_GEN_DEPENDENCIES = host-arm-gnu-toolchain ti-k3-r5-loader  
> 
> host-arm-gnu-toolchain is already a dependency of ti-k3-r5-loader so
> it should be already built a this point

It seems that ti-k3-image-gen also uses this bare-metal toolchain
directly, so it's fine and correct to have this dependency.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot