From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: Quentin Schulz <foss+buildroot@0leil.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] Makefile: make printvars target print all variables if no VARS set
Date: Mon, 1 Aug 2022 18:10:02 +0200 [thread overview]
Message-ID: <20220801161002.GD3168@scaer> (raw)
In-Reply-To: <eb16effd-22af-9004-ef2c-f330f351c5b6@theobroma-systems.com>
Quentin, All,
On 2022-08-01 17:15 +0200, Quentin Schulz spake thusly:
> On 8/1/22 17:12, Yann E. MORIN wrote:
> >On 2022-08-01 15:30 +0200, Quentin Schulz spake thusly:
> >>From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> >>VARS is not defined by default, meaning the filter will not return
> >>anything which ends up making `make printvars` also return nothing.
> >In fact, this is the expected behaviour, see fd5bd12379dc (Makefile:
> >printvars: don't print anything when VARS is not set).
> I should have made some research first it seems like :) Maybe we could print
> some error message if VARS is not set? In any case, unrelated to this patch.
Yeah, maybe... If you can come up with something that is not too ugly...
And don't forget to update the manual while at it. ;-]
> Sorry for the noise.
n.p.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-08-01 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 13:30 [Buildroot] [PATCH] Makefile: make printvars target print all variables if no VARS set Quentin Schulz
2022-08-01 15:12 ` Yann E. MORIN
2022-08-01 15:15 ` Quentin Schulz
2022-08-01 16:10 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801161002.GD3168@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=foss+buildroot@0leil.net \
--cc=quentin.schulz@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox