From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Sen Hastings <sen@phobosdpl.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/3] support/scripts/pkg-stats: make cells with many CVEs collapsible
Date: Mon, 1 Aug 2022 19:02:06 +0200 [thread overview]
Message-ID: <20220801190206.217f4117@windsurf> (raw)
In-Reply-To: <20220728232357.270130-1-sen@phobosdpl.com>
On Thu, 28 Jul 2022 18:23:55 -0500
Sen Hastings <sen@phobosdpl.com> wrote:
> Sometimes a package can have a lot of CVEs.
> Rather than have the CVE cell make a really tall row
> (that means you have to scroll a bunch) this collapses the CVE
> cell to a fixed size scrollable element with a
> sticky button that lets you expand and collapse it.
>
> If Javascript is enabled:
>
> A stylesheet is generated and appended before content rendering,
> amending the cells style to have a fixed height and overflow.
>
> Also, the expand/contract button is unhidden.
>
> This means the CVE cells are rendered in a collapsed state
> instead of being rendered in an expanded state and then
> slamming shut.
>
> This avoids a "flash" and *helps* (vertically at least) manage CLS
> (cumulative layout shift).
>
> see: https://web.dev/cls/
>
> If Javascript is disabled:
>
> The cells stay fully open and the expand/contract button stays hidden.
>
> Signed-off-by: Sen Hastings <sen@phobosdpl.com>
> ---
> support/scripts/pkg-stats | 38 ++++++++++++++++++++++++++++++++++++--
> 1 file changed, 36 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-08-01 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 23:23 [Buildroot] [PATCH 1/3] support/scripts/pkg-stats: make cells with many CVEs collapsible Sen Hastings
2022-07-28 23:23 ` [Buildroot] [PATCH 2/3] support/scripts/pkg-stats: adjust column widths Sen Hastings
2022-08-01 17:04 ` Thomas Petazzoni via buildroot
2022-08-01 18:11 ` Arnout Vandecappelle
2022-08-02 20:30 ` Sen Hastings
2022-08-02 22:04 ` Thomas Petazzoni via buildroot
2022-07-28 23:23 ` [Buildroot] [PATCH 3/3] support/scripts/pkg-stats: re-implement the sortable_hint Sen Hastings
2022-08-01 17:02 ` Thomas Petazzoni via buildroot
2022-08-01 17:02 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801190206.217f4117@windsurf \
--to=buildroot@buildroot.org \
--cc=sen@phobosdpl.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox