Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Sen Hastings <sen@phobosdpl.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/scripts/pkg-stats: add linebreak opportunity in CPE ID
Date: Wed, 3 Aug 2022 18:20:22 +0200	[thread overview]
Message-ID: <20220803182022.29e43972@windsurf> (raw)
In-Reply-To: <20220803153324.814454-1-sen@phobosdpl.com>

On Wed,  3 Aug 2022 10:33:24 -0500
Sen Hastings <sen@phobosdpl.com> wrote:

> This adds an optional linebreak at the vendor attribute in the CPE ID.
> 
> It should be noted this is purely for formatting/layout purposes
> and does not actually insert any additional characters
> (newline or otherwise) into the rendered text.
> 
> This means that even though the text renders across two lines,
> copy-pasting will still yield one line of text.
> 
> example: https://sen-h.github.io/pkg-stats/c245575.html
> 
> see also: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr
> 
> Signed-off-by: Sen Hastings <sen@phobosdpl.com>
> ---
>  support/scripts/pkg-stats | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied to master, thanks.

I had initially thought we would add a <wbr> at every : separator in
the CPE ID. Your choice to add only one after the 4th field makes the
code slightly more complex, but probably avoids wrapping occurring at
too many different locations. So I've applied as-is, we can always
revisit/improve if needed later.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-08-03 16:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 15:33 [Buildroot] [PATCH 1/1] support/scripts/pkg-stats: add linebreak opportunity in CPE ID Sen Hastings
2022-08-03 16:20 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220803182022.29e43972@windsurf \
    --to=buildroot@buildroot.org \
    --cc=sen@phobosdpl.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox