Re: [Buildroot] [PATCH 1/1 RESEND] package/python-construct: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Martin,

On Wed, 3 Aug 2022 17:42:48 +0200
Martin Povišer <povik+lin@cutebit.org> wrote:

> construct is a Python library for declarative serialization/
> deserialization of structured binary data.
> 
> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
> ---
> I don't know if you set a bar for the inclusion of packages in
> buildroot, but I think by its nature construct makes for a useful
> package on embedded systems.

Thanks for your contribution! It looked good, but there was one issue:
the patch was damaged, perhaps because you didn't send it using git
send-email?

So I fixed up the damage, but also added a test in our runtime test
infrastructure for this new package. This allows to verify that the
package works at runtime, which is quite important for Python modules.

See:

  support/testing/tests/package/test_python_construct.py

which builds a simple Buildroot configuration with python-construct
enabled, boots it under Qemu, and runs:

  support/testing/tests/package/sample_python_construct.py

inside this environment.

> +PYTHON_CONSTRUCT_DEPENDENCIES = host-python-setuptools-scm

I also dropped this dependency, because I couldn't see in setup.py why
this dependency would be needed, and a test build without this
dependency showed it was working. Hopefully I was not wrong on this :-)

See the final commit at:

  https://gitlab.com/buildroot.org/buildroot/-/commit/c05caa755723737e91ffd57e736298cb19c9c87f

Again, thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot