From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: Petr Vorel <pevik@seznam.cz>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/debianutils: bump version to 5.7-0.2
Date: Wed, 3 Aug 2022 23:57:22 +0200 [thread overview]
Message-ID: <20220803235722.63985959@windsurf> (raw)
In-Reply-To: <CAB1t1Cxs_U0rtKxoaWByef71KOrOeuL9_MpYM--TQCwS8eA0wA@mail.gmail.com>
Hello Petr,
On Fri, 29 Jul 2022 20:36:09 +0200
Petr Vorel <petr.vorel@gmail.com> wrote:
> I'm also a bit annoyed by patches like this that we cannot upstream
> > (and therefore have to keep forever), and that require AUTORECONF :-/
> >
> Understand, I'm sorry. I can either add po4a as host package to have it in
> build or discuss with Debian maintainer how to make translations (po4a
> non-mandatory).
> What do you prefer? Hope I'm now clear about the goal.
I would prefer to make translations not mandatory. Actually, there is
already some partial logic for it, but not used properly. The following
patch is probably a useful start:
diff --git a/Makefile.am b/Makefile.am
index 86ac499..d433444 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,6 +1,8 @@
AUTOMAKE_OPTIONS = foreign
+if TRANSLATE_DOCS
SUBDIRS = po4a
+endif
EXTRA_DIST = CHANGELOG CONTRIBUTING .gitlab-ci.yml
diff --git a/po4a/de/Makefile.am b/po4a/de/Makefile.am
index 11f0094..d14e297 100644
--- a/po4a/de/Makefile.am
+++ b/po4a/de/Makefile.am
@@ -3,11 +3,7 @@ AUTOMAKE_OPTIONS=foreign
l = de
addendum = -a $(top_srcdir)/po4a/$(l)/translator_german.add
-if TRANSLATE_DOCS
- TRANSLATE = po4a-translate -k 0 -f man $(addendum) -p $(top_srcdir)/po4a/po/$(l).po
-else
- TRANSLATE = @echo po4a-translate not installed, failing to rebuild changed man page translation; exit 1;
-endif
+TRANSLATE = po4a-translate -k 0 -f man $(addendum) -p $(top_srcdir)/po4a/po/$(l).po
EXTRA_DIST = translator_german.add
TRANSLATE_DOCS is already provided by configure.ac, depending on
whether po4a is available or not.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-03 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 19:38 [Buildroot] [PATCH 1/1] package/debianutils: bump version to 5.7-0.2 Petr Vorel
2022-07-26 20:04 ` Thomas Petazzoni via buildroot
2022-07-29 18:36 ` Petr Vorel
2022-08-03 21:57 ` Thomas Petazzoni via buildroot [this message]
2022-08-04 21:27 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803235722.63985959@windsurf \
--to=buildroot@buildroot.org \
--cc=petr.vorel@gmail.com \
--cc=pevik@seznam.cz \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox