From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [git commit] Makefile: error out printvars target when VARS is empty or unset
Date: Thu, 4 Aug 2022 23:16:28 +0200 [thread overview]
Message-ID: <20220804211628.GA3501245@scaer> (raw)
In-Reply-To: <ffe375e2a41b4e069ce2632c28cea51d@AcuMS.aculab.com>
DAvid, All,
On 2022-08-04 08:00 +0000, David Laight spake thusly:
> From: Yann E.MORIN
> > An error message making explicit what is required from the user in order
> > to use printvars is however better than silently doing nothing.
[--SNIP--]
> > printvars:
> > +ifndef VARS
> > + @echo "Please pass a non-empty VARS to 'make printvars'"
> Shouldn't that have a >&2 ??
As usgested by Arnout, I changed that to use $(error).
Thanks for the nudge!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-08-04 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 17:05 [Buildroot] [git commit] Makefile: error out printvars target when VARS is empty or unset Yann E. MORIN
2022-08-04 8:00 ` David Laight
2022-08-04 11:47 ` Quentin Schulz
2022-08-04 15:08 ` Arnout Vandecappelle
2022-08-04 21:16 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804211628.GA3501245@scaer \
--to=yann.morin.1998@free.fr \
--cc=David.Laight@ACULAB.COM \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox