Re: [Buildroot] [PATCH v3] package/ccache: bump version to 4.6.1

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks for your work!

I did not do a thorough review, but I spotted something that needs to
be change, see below.

On Fri,  5 Aug 2022 13:13:41 +0000
Dominik Michael Rauh <dmrauh@posteo.de> wrote:

> +config BR2_CCACHE_REDIS_BACKEND
> +	bool "Enable Redis storage backend"
> +	default n

This is not needed, the default for an option is to be disabled.

> +	select BR2_PACKAGE_HIREDIS

This is not correct, as it enables hiredis for the target, which we
don't want. Just don't select anything here.

> +HOST_CCACHE_CONF_OPTS += \
> +	-UCMAKE_C_COMPILER_LAUNCHER \
> +	-UCMAKE_CXX_COMPILER_LAUNCHER

Just curious, what are these doing?

> diff --git a/package/cmake/cmake.mk b/package/cmake/cmake.mk
> index 053658fad6..eae12c1465 100644
> --- a/package/cmake/cmake.mk
> +++ b/package/cmake/cmake.mk
> @@ -40,9 +40,16 @@ CMAKE_CONF_OPTS = \
>  HOST_CMAKE_CFLAGS = $(shell echo $(HOST_CFLAGS) | sed -r "s%$(HOST_CPPFLAGS)%%")
>  HOST_CMAKE_CXXFLAGS = $(shell echo $(HOST_CXXFLAGS) | sed -r "s%$(HOST_CPPFLAGS)%%")
>  
> +# we are built before ccache
> +HOST_CMAKE_CONFIGURE_OPTS = \
> +	$(HOST_CONFIGURE_OPTS) \
> +	CC="$(HOSTCC_NOCCACHE)" \
> +	GCC="$(HOSTCC_NOCCACHE)" \
> +	CXX="$(HOSTCXX_NOCCACHE)"
> +
>  define HOST_CMAKE_CONFIGURE_CMDS
>  	(cd $(@D); \
> -		$(HOST_CONFIGURE_OPTS) \
> +		$(HOST_CMAKE_CONFIGURE_OPTS) \

It's really a pity that we need to disable ccache support to build
host-cmake, because host-cmake is notoriously slow to build... But
obviously since ccache is now using cmake as its build system, I don't
really see a much better solution.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot