Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: kory.maincent@bootlin.com, Jens Kleintje <scooby22@web.de>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/gcnano-binaries: set Version: field in .pc files
Date: Fri, 5 Aug 2022 18:35:34 +0200	[thread overview]
Message-ID: <20220805163534.GF3621445@scaer> (raw)
In-Reply-To: <20220804204157.30731-2-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2022-08-04 22:41 +0200, Thomas Petazzoni via buildroot spake thusly:
> All .pc files have a Version field set to #VERSION#, which needs to be
> replaced, otherwise packages checking the version of OpenGL ES, EGL,
> GBM, etc. will fail. For example:
> 
> Dependency gbm found: NO unknown version, but need: ['>=17.1.0']
> 
> Such problems have been seen with both libepoxy and SDL2.
> 
> The version 21.1.1 is chosen because it matches what the Yocto recipe
> is doing for this package:
> 
>   https://github.com/STMicroelectronics/meta-st-stm32mp/blob/kirkstone/recipes-graphics/gcnano-userland/gcnano-userland.inc#L42

... which they did not provide any explanation for...

> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/gcnano-binaries/gcnano-binaries.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gcnano-binaries/gcnano-binaries.mk b/package/gcnano-binaries/gcnano-binaries.mk
> index ce9b24cc3a..d9c47bf64e 100644
> --- a/package/gcnano-binaries/gcnano-binaries.mk
> +++ b/package/gcnano-binaries/gcnano-binaries.mk
> @@ -60,7 +60,7 @@ define GCNANO_BINARIES_INSTALL
>  	ln -sf gbm/gbm.h $(1)/usr/include/gbm.h
>  	cd $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/pkgconfig/ ; \
>  	for file in *.pc ; do \
> -		sed -e "s|#PREFIX#|/usr|" $$file > $$file.temp ; \
> +		sed -e "s|#PREFIX#|/usr|" -e "s|#VERSION#|21.1.1|" $$file > $$file.temp ; \
>  		$(INSTALL) -D -m 0644 $$file.temp $(1)/usr/lib/pkgconfig/$$file ; \
>  	done
>  endef
> -- 
> 2.37.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-05 16:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 20:41 [Buildroot] [PATCH 1/2] package/gcnano-binaries: create symlinks for libGLESv2 and libGLESv1_CM.so Thomas Petazzoni via buildroot
2022-08-04 20:41 ` [Buildroot] [PATCH 2/2] package/gcnano-binaries: set Version: field in .pc files Thomas Petazzoni via buildroot
2022-08-05 16:35   ` Yann E. MORIN [this message]
2022-08-06 13:40     ` Thomas Petazzoni via buildroot
2022-08-05 16:33 ` [Buildroot] [PATCH 1/2] package/gcnano-binaries: create symlinks for libGLESv2 and libGLESv1_CM.so Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805163534.GF3621445@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=kory.maincent@bootlin.com \
    --cc=scooby22@web.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox