Re: [Buildroot] [RFC v3 1/2] package/pkg-meson.mk: support fortran cross-compilation

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

+Yann in Cc, as there is an open issue, see below.

On Fri,  5 Aug 2022 16:36:24 +0200
"Guillaume W. Bres" <guillaume.bressaix@gmail.com> wrote:

> python-scipy is moving to a meson build infrastructure,
> and requires fortran cross-compilation
> 
> Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
> ---
>  package/pkg-meson.mk                   | 2 ++
>  support/misc/cross-compilation.conf.in | 3 +++
>  2 files changed, 5 insertions(+)

I applied to master... but I went too fast, there were several
incorrect things in this commit.

+        -e "s%@TARGET_FCFLAGS@%$(call make-sq-comma-list,$($(strip $(2))))%g" \

this is wrong: $(2) in PKG_MESON_CROSSCONFIG_SED contains the CXXFLAGS,
not the FCFLAGS. So I changed that to $(4), and passed FCFLAGS as a
fourth argument to this macro.

Also, you were missing setting FCFLAGS in the
PKG_MESON_INSTALL_CROSS_CONF macro.

I fixed this in a follow-up commit:
https://git.buildroot.org/buildroot/commit/?id=cd933d676f210789730ecb25b23d902620d72072.
I hope I got it right.

Now, on to the open issue which explains why I have added Yann in Cc.
We are currently setting the C++ compiler and Fortran compiler path in
Meson's cross-compilation.conf unconditionally... even when the
toolchain has no C++ or Fortran support. So it means we're pointing to
compilers that don't exist.

Ideally, the cross-compilation.conf should be generated with no
reference to a C++ or Fortran compiler, or a /bin/false reference, and
ditto for the CXXFLAGS/FCFLAGS when there is no C++ or Fortran support.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot