From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Joseph Kogut <joseph.kogut@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libnss: fix build failure due to missing missing libnspr in link list
Date: Sun, 7 Aug 2022 00:21:23 +0200 [thread overview]
Message-ID: <20220807002123.6ad5ef3b@windsurf> (raw)
In-Reply-To: <20220806153651.4013424-1-giulio.benetti@benettiengineering.com>
On Sat, 6 Aug 2022 17:36:51 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> FREEBL_NO_DEPEND is usually set to 1 and this means that:
> ```
> build libfreebl3.so with no NSPR and libnssutil3.so dependencies by
> default
> ```
> But PR_SetError() and other PR_*() APIs are contained right in
> NSPR(libnspr) that we already build and it's a libnss dependency, so let's
> make libnss to link with libnspr by default by setting FREEBL_NO_DEPEND to
> 0.
>
> Fixes:
> http://autobuild.buildroot.net/results/c5b440bae5cd6dc6d5f1a632a6b5950b32d13f66/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Thanks for the debugging, but I have to say I am not convinced by the
explanation. Why is FREEBL_NO_DEPEND=1 the default if it doesn't work?
Why was it working before, and what broke it?
Setting or not setting FREEBL_NO_DEPEND has impact in a lot of parts of
the libnss code, I don't think we should do this lightly.
Could you research more when this broke (i.e which version bump in
Buildroot), and then which commit in NSS causes this breakage? I don't
want to blindly set this obscure variable.
Has this issue been reported upstream?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-06 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 15:36 [Buildroot] [PATCH] package/libnss: fix build failure due to missing missing libnspr in link list Giulio Benetti
2022-08-06 22:21 ` Thomas Petazzoni via buildroot [this message]
2022-08-08 23:34 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220807002123.6ad5ef3b@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=joseph.kogut@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox