Re: [Buildroot] [PATCH v1 1/1] package/rtl8821cu: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Christian,

On Sun, 24 Jul 2022 17:01:11 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:

> Adds support for USB rtl8821cu wifi cards.
> 
> Similar to rtl8821au and rtl8812au-aircrack-ng packages.
> 
> https://github.com/morrownr/8821cu-20210118
> 
> Signed-off-by: Christian Stewart <christian@paral.in>
> ---
>  package/Config.in                             |    1 +
>  ...platform-specific-and-build-on-targe.patch | 1225 +++++++++++++++++
>  ...ate-time-remove-date-and-time-macros.patch |   30 +
>  package/rtl8821cu/Config.in                   |   10 +
>  package/rtl8821cu/rtl8821cu.hash              |    3 +
>  package/rtl8821cu/rtl8821cu.mk                |   19 +
>  6 files changed, 1288 insertions(+)

Entry in DEVELOPERS file is missing.

> diff --git a/package/rtl8821cu/0001-makefile-remove-platform-specific-and-build-on-targe.patch b/package/rtl8821cu/0001-makefile-remove-platform-specific-and-build-on-targe.patch
> new file mode 100644
> index 0000000000..ec838eb1b8
> --- /dev/null
> +++ b/package/rtl8821cu/0001-makefile-remove-platform-specific-and-build-on-targe.patch
> @@ -0,0 +1,1225 @@
> +From de579638554590973ce0086f39be4bd6a8ef1c15 Mon Sep 17 00:00:00 2001
> +From: Christian Stewart <christian@paral.in>
> +Date: Mon, 7 Mar 2022 11:33:23 -0800
> +Subject: [PATCH] makefile: remove platform-specific and build-on-target
> + sections
> +
> +Simplify the makefile, removing broken platform-specific sections.
> +
> + - unset platform i386-pc
> + - remove all platform sections
> + - remove sections assuming build-on-target
> +
> +Signed-off-by: Christian Stewart <christian@paral.in>
> +
> +makefile: remove sections assuming build-on-target
> +
> +Removed all sections which assume the driver is being built on the target.
> +
> +Signed-off-by: Christian Stewart <christian@paral.in>

Why this patch seems to have 2 commits logs one after the other?

Also, can we find a change that is acceptable by upstream, instead of this huge patch?

> diff --git a/package/rtl8821cu/0002-error-date-time-remove-date-and-time-macros.patch b/package/rtl8821cu/0002-error-date-time-remove-date-and-time-macros.patch
> new file mode 100644
> index 0000000000..d51c11fa64
> --- /dev/null
> +++ b/package/rtl8821cu/0002-error-date-time-remove-date-and-time-macros.patch
> @@ -0,0 +1,30 @@
> +From aece6cb25704d86bfea9a4ad8b79970471ac5059 Mon Sep 17 00:00:00 2001
> +From: Christian Stewart <christian@paral.in>
> +Date: Mon, 7 Mar 2022 11:44:38 -0800
> +Subject: [PATCH] error date-time: remove date and time macros
> +
> +Fixes: -Werror=date-time
> +
> +error: macro "__TIME__" might prevent reproducible builds
> +
> +Signed-off-by: Christian Stewart <christian@paral.in>
> +---
> + core/rtw_debug.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/core/rtw_debug.c b/core/rtw_debug.c
> +index d1a41e1..e16efa5 100755
> +--- a/core/rtw_debug.c
> ++++ b/core/rtw_debug.c
> +@@ -42,7 +42,7 @@ const char *rtw_log_level_str[] = {
> + void dump_drv_version(void *sel)
> + {
> + 	RTW_PRINT_SEL(sel, "%s %s\n", DRV_NAME, DRIVERVERSION);
> +-	RTW_PRINT_SEL(sel, "build time: %s %s\n", __DATE__, __TIME__);
> ++	RTW_PRINT_SEL(sel, "build time: [unset] [unset]\n");
> + }
> + 
> + #ifdef CONFIG_PROC_DEBUG
> +-- 
> +2.35.1
> +

It would be nice to not force -Werror=date-time, because in Buildroot,
when BR2_REPRODUCIBLE=y, we make sure that the __DATE__ and __TIME__
macros from gcc expand to a well-defined and constant value.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot