Re: [Buildroot] [PATCH 1/2] support/testing: octave: increase test timeout

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Julien,

On Sun,  7 Aug 2022 18:55:37 +0200
Julien Olivain <ju.o@free.fr> wrote:

> Octave package test can occasionally fail due to timeout.
> This commit slightly increase timeout values to reduce those failures.
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
>  support/testing/tests/package/test_octave.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/support/testing/tests/package/test_octave.py b/support/testing/tests/package/test_octave.py
> index 82a70e09c2..2d808e0cca 100644
> --- a/support/testing/tests/package/test_octave.py
> +++ b/support/testing/tests/package/test_octave.py
> @@ -34,6 +34,7 @@ class TestOctave(infra.basetest.BRTest):
>                             kernel=kern,
>                             kernel_cmdline=["console=ttyAMA0"],
>                             options=["-M", "virt", "-cpu", "cortex-a57", "-m", "512M", "-initrd", img])
> +        self.emulator.timeout_multiplier *= 2

Thanks for the patch.

I know a few other tests are tweaking timeout_multiplier, but I think
it's wrong. The idea of timeout_multiplier is that it's defined on the
command line, when running the tests, to indicate that you're running
on a "slow" machine that requires a timeout factor.

Tests should only tweak the timeout value, and the timeout_multiplier
will be applied to these timeouts.

So I think we should remove these tweaks on timeout_multiplier in test
cases, rather than add more.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot