Re: [Buildroot] [PATCH] configs/kontron_bl_imx8mm_defconfig: fix build failure with u-boot 2022.04

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] configs/kontron_bl_imx8mm_defconfig: fix build failure with u-boot 2022.04
Date: Mon, 8 Aug 2022 10:41:33 +0200	[thread overview]
Message-ID: <20220808104133.6479c0a5@windsurf> (raw)
In-Reply-To: <20220807210317.9415-1-heiko.thiery@gmail.com>

Hello Heiko,

Thanks for the patch!

On Sun,  7 Aug 2022 23:03:18 +0200
Heiko Thiery <heiko.thiery@gmail.com> wrote:

> +-HOSTLDLIBS_mkeficapsule += -lgnutls -luuid
> ++HOSTLDLIBS_mkeficapsule += \
> ++	$(shell pkg-config --libs gnutls uuid 2> /dev/null || echo "-lgnutls -luuid")

Do you understand why this is needed?

In the build failure reported by Gitlab CI, it fails to find libgnutls,
even though host-gnutls has been built before. So the -lgnutls that was
in HOSTLDLIBS_mkeficapsule should have been sufficient, provided
$(HOST_LDFLAGS) are properly used.

Of course, I have nothing against using pkg-config, but I was just
wondering if we have an explanation on what was going on. And is
pkg-config fixing it because it's return a full path to the library?

Obviously, one issue with your patch is that it's going to fix the
problem only for the kontron defconfig, which is why I was interested
to see if there wasn't a better solution.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot