From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
James Hilliard <james.hilliard1@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/serd: bump to version 0.30.14
Date: Mon, 8 Aug 2022 22:47:31 +0200 [thread overview]
Message-ID: <20220808224731.7a316fbb@windsurf> (raw)
In-Reply-To: <CAPi7W80GOh-GQzB6u11MG69qn1GLWKT4VEGrkz53S-bofiWr_g@mail.gmail.com>
On Mon, 8 Aug 2022 22:39:00 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> If -Dstatic is true, -static will be added to tool_link_args to statically
> link executables:
>
> if get_option('static')
> tool_link_args += ['-static']
> endif
>
> So, indeed, the static option is probably only useful when both shared and
> static libraries are built (i.e. with BR2_SHARED_STATIC_LIBS) to force the
> tools to be statically linked.
> I can drop it if you want.
I'm not sure to follow you: when BR2_SHARED_STATIC_LIBS=y, we do *not*
want tools to be statically linked.
In addition, your patch was passing -Dstatic=true only when
BR2_STATIC_LIBS=y, so when BR2_SHARED_STATIC_LIBS=y was passed your
patch was passing -Dstatic=false.
I believe we should pass -Dstatic=false unconditionally. Of course,
give it a test with BR2_STATIC_LIBS=y, and see if the build works fine,
but I believe it should.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-08-08 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 15:14 [Buildroot] [PATCH 1/2] package/serd: bump to version 0.30.14 Fabrice Fontaine
2022-08-08 15:14 ` [Buildroot] [PATCH 2/2] package/sord: bump to version 0.16.12 Fabrice Fontaine
2022-08-08 20:31 ` [Buildroot] [PATCH 1/2] package/serd: bump to version 0.30.14 Thomas Petazzoni via buildroot
2022-08-08 20:39 ` Fabrice Fontaine
2022-08-08 20:47 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808224731.7a316fbb@windsurf \
--to=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=fontaine.fabrice@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox