From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Romain Naour <romain.naour@gmail.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/xenomai: always set default version
Date: Tue, 9 Aug 2022 13:39:32 +0200 [thread overview]
Message-ID: <20220809133932.721b8cd8@windsurf> (raw)
In-Reply-To: <20220808215404.1804219-1-fontaine.fabrice@gmail.com>
On Mon, 8 Aug 2022 23:54:04 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Always set a default value for BR2_PACKAGE_XENOMAI_VERSION to avoid a
> build failure when BR2_PACKAGE_XENOMAI_VERSION is empty with
> BR2_PACKAGE_XENOMAI_CUSTOM_{GIT,VERSION}
>
> Fixes:
> - http://autobuild.buildroot.org/results/d80c295a848b5be69324f5dfbd269b046dc68e8c
> - http://autobuild.buildroot.org/results/4e57a499b43208e546dd962ca04b43408c0c082c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/xenomai/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index ec6d9e5d29..5c179eec72 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -73,8 +73,8 @@ config BR2_PACKAGE_XENOMAI_VERSION
> string "Custom Xenomai version" if \
> !BR2_PACKAGE_XENOMAI_LATEST_VERSION && \
> !BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
> - default "3.0.10" if BR2_PACKAGE_XENOMAI_LATEST_VERSION
> default "custom" if BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
> + default "3.0.10"
Meh, I don't like how Xenomai handles things differently than all other
packages that have a configurable version.
IMO, we should make Xenomai look like the other packages, which means:
- Dropping default "https://gitlab.denx.de/Xenomai/xenomai.git"
- Not have any default value for BR2_PACKAGE_XENOMAI_VERSION
We really want consistency on how this "custom version" thing is
handled.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-09 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 21:54 [Buildroot] [PATCH 1/1] package/xenomai: always set default version Fabrice Fontaine
2022-08-09 11:39 ` Thomas Petazzoni via buildroot [this message]
2022-08-09 12:12 ` Fabrice Fontaine
2022-08-09 13:54 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809133932.721b8cd8@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox