Re: [Buildroot] [PATCH 4/4] package/gdb: remove BR2_PACKAGE_GDB_TOPLEVEL

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thomas, All,

On 2022-08-13 10:35 +0200, Thomas Petazzoni via buildroot spake thusly:
> This option was needed to build versions of GDB < 10.x. As we just
> dropped support for GDB 9.x, this logic can now be removed.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
[--SNIP--]
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index d2bbfcb290..45ce126bab 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -18,23 +18,14 @@ GDB_LICENSE = GPL-2.0+, LGPL-2.0+, GPL-3.0+, LGPL-3.0+
>  GDB_LICENSE_FILES = COPYING COPYING.LIB COPYING3 COPYING3.LIB
>  GDB_CPE_ID_VENDOR = gnu
>  
> -# On gdb < 10, if you want to build only gdbserver, you need to
> -# configure only gdb/gdbserver.
> -ifeq ($(BR2_PACKAGE_GDB_DEBUGGER)$(BR2_PACKAGE_GDB_TOPLEVEL),)
> -GDB_SUBDIR = gdb/gdbserver

I got slightly confused here, so I added a little blurb in the commit
log to explain that it is correct to drop this.

Applied to next, thanks.

Regards,
Yann E. MORIN.

> -# When we want to build the full gdb, or for very recent versions of
> -# gdb with gdbserver at the top-level, out of tree build is mandatory,
> -# so we create a 'build' subdirectory in the gdb sources, and build
> -# from there.
> -else
> +# Out of tree build is mandatory, so we create a 'build' subdirectory
> +# in the gdb sources, and build from there.
>  GDB_SUBDIR = build
>  define GDB_CONFIGURE_SYMLINK
>  	mkdir -p $(@D)/$(GDB_SUBDIR)
>  	ln -sf ../configure $(@D)/$(GDB_SUBDIR)/configure
>  endef
>  GDB_PRE_CONFIGURE_HOOKS += GDB_CONFIGURE_SYMLINK
> -endif
>  
>  # For the host variant, we really want to build with XML support,
>  # which is needed to read XML descriptions of target architectures. We
> -- 
> 2.37.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot