From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Jared Bents <jared.bents@rockwellcollins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3, 2/2] package/libvirt: fix libvirtd dependency
Date: Mon, 15 Aug 2022 11:42:23 +0200 [thread overview]
Message-ID: <20220815094223.GS2854108@scaer> (raw)
In-Reply-To: <20220814182734.2878423-2-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2022-08-14 20:27 +0200, Fabrice Fontaine spake thusly:
> Commit 4dff1be05e90 (package/libvirt: libvirtd needs C++ for nmap-ncat)
> introduce a recursive dependency (really: a circular dependency):
>
> package/busybox/Config.in:33:error: recursive dependency detected!
> package/busybox/Config.in:33: symbol BR2_PACKAGE_BUSYBOX_SHOW_OTHERS is selected by BR2_PACKAGE_EBTABLES_UTILS_SAVE
> package/ebtables/Config.in:11: symbol BR2_PACKAGE_EBTABLES_UTILS_SAVE depends on BR2_PACKAGE_EBTABLES
> package/ebtables/Config.in:1: symbol BR2_PACKAGE_EBTABLES is selected by BR2_PACKAGE_LIBVIRT_DAEMON
> package/libvirt/Config.in:44: symbol BR2_PACKAGE_LIBVIRT_DAEMON depends on BR2_PACKAGE_NETCAT_OPENBSD
> package/netcat-openbsd/Config.in:1: symbol BR2_PACKAGE_NETCAT_OPENBSD depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>
> We can't drop the C++ dependency and switch the netcat-openbsd and
> nmap-ncat dependencies conditions without adding a glibc dependency.
>
> So always mandate C++ even if is only needed by nmap and not
*if it is...
> netcat-openbsd
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Changes v2 -> v3 (after review of Thomas Petazzoni):
> - Always mandate C++ instead of glibc
>
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Fix patch (rebase on top of current master)
>
> package/libvirt/Config.in | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> index afd2372d0e..c404d1b0e2 100644
> --- a/package/libvirt/Config.in
> +++ b/package/libvirt/Config.in
> @@ -38,7 +38,7 @@ if BR2_PACKAGE_LIBVIRT
> config BR2_PACKAGE_LIBVIRT_DAEMON
> bool "libvirtd"
> default y
> - depends on BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_NETCAT_OPENBSD # nmap
> + depends on BR2_INSTALL_LIBSTDCPP # nmap
> select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> select BR2_PACKAGE_DNSMASQ
> select BR2_PACKAGE_EBTABLES
> @@ -52,6 +52,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON
> Build the libvirt daemon (libvirtd) otherwise build only the
> utility programs.
>
> +comment "libvirtd needs a toolchain w/ C++"
> + depends on !BR2_INSTALL_LIBSTDCPP
> +
> # Stateful drivers are useful only when building the daemon.
> if BR2_PACKAGE_LIBVIRT_DAEMON
>
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-15 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 18:27 [Buildroot] [PATCH v3, 1/2] Revert "package/libvirtd: fix recursive dependency in Kconfig" Fabrice Fontaine
2022-08-14 18:27 ` [Buildroot] [PATCH v3, 2/2] package/libvirt: fix libvirtd dependency Fabrice Fontaine
2022-08-15 9:42 ` Yann E. MORIN [this message]
2022-09-16 12:04 ` Peter Korsgaard
2022-08-15 9:41 ` [Buildroot] [PATCH v3, 1/2] Revert "package/libvirtd: fix recursive dependency in Kconfig" Yann E. MORIN
2022-08-15 9:57 ` Yann E. MORIN
2022-09-16 12:04 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815094223.GS2854108@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=jared.bents@rockwellcollins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox