Re: [Buildroot] [PATCH] support/download/git: disable global & system config

["Yann E. MORIN" <yann.morin.1998@free.fr>]

John, All,

On 2022-08-15 11:46 +0100, John Keeping spake thusly:
> On Sun, Aug 14, 2022 at 12:11:43AM +0200, Yann E. MORIN wrote:
> > On 2022-08-11 14:45 +0100, John Keeping spake thusly:
> > > The build environment should be isolated from the host system as much as
> > > possible to keep the build reproducible.  Git's global config (usually
> > > ~/.gitconfig) and system config (/etc/gitconfig) can affect the
> > > behaviour of all Git operations, so should be disabled.
> > While I appreciate the reasoning and example, there are valid cases
> > where we do want to use (at least) the user's settings, [...]
> What do you thing about adding a config option to specify the global
> gitconfig file to use?
[--SNIP--]
> 	eval ${BR2_GIT_CONFIG_GLOBAL:+GIT_CONFIG_GLOBAL=\'${BR2_GIT_CONFIG_GLOBAL}\'} \
> 		GIT_DIR="${git_cache}/.git" ${GIT} "${@}"

Honestly, I don't think the issue warrants extra complexity.

For your git-lfs example, we would notice a missing FO_GIT_LFS fairly
quickly, thanks to the autobuilders. So this is not a big issue for
packages in upstream Buildroot; for br2-external trees, this is most
probably not an issue either: either all developpers ona project have
the same settings, or they are using a sane build environment, or they
would also notice, so this is not very important.

Hwever, there are settings that we would probably want to always
disable, like line-ending mangling (core.autocrlf or gitattributes) or
other keyword replacement (gitattributes 'ident' or 'filter'...). But
then, we haven't had much report about such failures, if at all, so this
does not look like a problem in practice.

So, I still don't think we need to add complexity to solve this issue.
If we can get something really simple, that's OK, but no nuclear
powerplant please. ;-)

> The system config is less likely to be problematic as I don't think it's
> used much outside managed environments where the content probably is for
> proxy settings that should be included in Buildroot.

Yes, I agree that system-wide config file should be Mostly Harmless (C).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot