Re: [Buildroot] [PATCH] package/gnuradio: bump version to 3.10.3.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Mon,  8 Aug 2022 10:09:10 +0200
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:

> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> - remove all no more required patches
> - add dependency to SPDLOG
> - add pybind dependency where python is set
> 
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

Thanks for this version bump. A few questions below.

>  	select BR2_PACKAGE_PYTHON_NUMPY # runtime
> +	select BR2_PACKAGE_PYTHON_PYBIND # runtime

So here you're saying that python-numpy and python-pybind are runtime
dependencies.

>  ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y)
> -GNURADIO_DEPENDENCIES += python3
> +GNURADIO_DEPENDENCIES += python3 python-numpy python-pybind \

But you have them as build-time dependencies here. Could you check this?

> +	host-python-mako host-python-numpy host-python-packaging

Are these host-python-* really needed? Why would gnuradio needs numpy
at build time? Or are they just here to satisfy some broken build
system that verifies NumPy is installed on the build machine, even
though really they are needed only on the target?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot