From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07242C25B08 for ; Sat, 20 Aug 2022 09:28:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 88B5A60E4C; Sat, 20 Aug 2022 09:28:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 88B5A60E4C X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AxITMehKTrWq; Sat, 20 Aug 2022 09:28:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 9E3E160E3A; Sat, 20 Aug 2022 09:28:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9E3E160E3A Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 982261BF2C5 for ; Sat, 20 Aug 2022 09:28:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 799DD60D79 for ; Sat, 20 Aug 2022 09:28:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 799DD60D79 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qrRhVArlPluz for ; Sat, 20 Aug 2022 09:28:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0B72A60D77 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0B72A60D77 for ; Sat, 20 Aug 2022 09:28:47 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 1D1FA60006; Sat, 20 Aug 2022 09:28:43 +0000 (UTC) Date: Sat, 20 Aug 2022 11:28:42 +0200 To: Thomas Petazzoni via buildroot Message-ID: <20220820112842.7bcd12f2@windsurf> In-Reply-To: <20220814123748.167ebb02@windsurf> References: <20220812101718.47491-1-fontaine.fabrice@gmail.com> <20220814123748.167ebb02@windsurf> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1660987725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+tDmcva8Vhw0FnlBuGTWhGe2kpgdQrBPkFYci7Msgmc=; b=LegycziyS0xNQhBV+VoE5eg2CNj80lYyF69nZprRylD0nFJM1lmX/n0Ud94nlkB3or+CAv qt22TeD6o0IZyiR1OhhwIFhf48wB/FH+PxbBjNQQEhu+5hmXgjIdW0fbbFWVpXuoBCvEzy sEB6E/151I7pA3m27arxXleM+ZvIQmku6OzrJPrsM6XuXw/bMueUIsN2qs1TpU5dVf06S2 CHOsValAumJZFKox0+zk49kk6yVjjeO6fvWF8vK4j/j64rqX2SVRfsd+xH/znRuaewWm7B XClFeFPOVFNOdKd9s8CSJc9yuTgVyloPVBbPVNwTRzuNrrUyTW3eMv70TdvVaQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Legycziy Subject: Re: [Buildroot] [PATCH v2, 1/1] package/poppler: fix introspection build X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Petazzoni via buildroot Reply-To: Thomas Petazzoni Cc: Adam Duskett , Olivier Schonken , Fabrice Fontaine , Thomas Petazzoni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hello Fabrice, Do you have some feedback? Or perhaps Adam? Thanks! Thomas On Sun, 14 Aug 2022 12:37:48 +0200 Thomas Petazzoni via buildroot wrote: > Hello Fabrice, > > +Adam Duskett for GOI expertise. > > On Fri, 12 Aug 2022 12:17:18 +0200 > Fabrice Fontaine wrote: > > > diff --git a/package/poppler/poppler.mk b/package/poppler/poppler.mk > > index b54262e7c4..db6da25d39 100644 > > --- a/package/poppler/poppler.mk > > +++ b/package/poppler/poppler.mk > > @@ -47,7 +47,8 @@ POPPLER_DEPENDENCIES += gobject-introspection > > POPPLER_CONF_OPTS += \ > > -DENABLE_GOBJECT_INTROSPECTION=ON \ > > -DINTROSPECTION_SCANNER=$(STAGING_DIR)/usr/bin/g-ir-scanner \ > > - -DINTROSPECTION_COMPILER=$(STAGING_DIR)/usr/bin/g-ir-compiler > > + -DINTROSPECTION_COMPILER=$(STAGING_DIR)/usr/bin/g-ir-compiler \ > > + -DINTROSPECTION_COMPILER_ARGS="--includedir=$(STAGING_DIR)/usr/share/gir-1.0" > > else > > POPPLER_CONF_OPTS += -DENABLE_GOBJECT_INTROSPECTION=OFF > > endif > > I am really not familiar with all the gobject-introspection stuff, but > I'm wondering if this is the right solution for this problem. > > In package/gobject-introspection/, I can see that we create and install > a g-ir-scanner wrapper that passes --add-include-path="$(dirname > "$0")"/../share/gir-1.0. > > In this same directory, we also have a g-ir-compiler wrapper, which is > used to execute things in Qemu. If a special path is needed, why don't > we pass it within this wrapper, so that the solution works for all > packages? > > Apparently, according to > package/libglib2/0004-meson.build-add-girdir-to-gio-2.0.pc-and-glib-2.0.pc.patch > there are some packages that set girdir in their .pc file so that other > packages now where to find the GIR files. > > Really not clear in my mind how all of this should work. My only > concern is that I would like us to find and use the same solution > everywhere to solve the same problem, rather than having 10 different > solutions for each package encountering the same issue. > > Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot