Re: [Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling

["Yann E. MORIN" <yann.morin.1998@free.fr>]

On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
> Add a custom case to make sure that a random configuration with an empty
> theme for jquery-ui-themes doesn't fail. It reverts to
> BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE in that case.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/b38f605795b1c60d8253313ce9478c4b1991d390
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  utils/genrandconfig | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/utils/genrandconfig b/utils/genrandconfig
> index 85db7ed1e9..9d2ed3f244 100755
> --- a/utils/genrandconfig
> +++ b/utils/genrandconfig
> @@ -547,6 +547,11 @@ def fixup_config(sysinfo, configfile):
>          if 'BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT=y\n' in configlines:
>              return False
>  
> +    if 'BR2_PACKAGE_JQUERY_UI_THEMES=y\n' in configlines and \
> +       'BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n' in configlines:

I am not sure how we can end up with an empty BR2_PACKAGE_JQUERY_UI_THEMES_THEME.
Indeed, it is filled from a choice, and unless there is a typo in one of
the config options, there are as many defaults for it as there are
entries in the choice...

And if you look at the .config file, there is actually something
selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but
indeed BR2_PACKAGE_JQUERY_UI_THEMES_THEME is not even set. It's not that
it is empty, it is not set at all!

So, the .config file is not correct.

So, I think the issue is about fixing genrandconfig to generate .config
files that are correct to begin with. Priobably, running "make
olddefconfig" before checking the configuration is required? At least,
when I do that localy, the .config now properly contains
BR2_PACKAGE_JQUERY_UI_THEMES_THEME="vader".

But wait, wait... We already run 'make olddefconfig'! What's going on
here?

Regards,
Yann E. MORIN.

> +        configlines.append('BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y\n')
> +        configlines.remove('BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n')
> +
>      if 'BR2_TARGET_OPENSBI=y\n' in configlines and \
>         'BR2_TARGET_OPENSBI_CUSTOM_GIT=y\n' in configlines and \
>         'BR2_TARGET_OPENSBI_CUSTOM_REPO_URL=""\n' in configlines:
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot